From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06C0C433F5 for ; Thu, 10 Mar 2022 14:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7EF8D0002; Thu, 10 Mar 2022 09:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6805A8D0001; Thu, 10 Mar 2022 09:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 521D48D0002; Thu, 10 Mar 2022 09:45:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 3E2898D0001 for ; Thu, 10 Mar 2022 09:45:33 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EE9D694FC0 for ; Thu, 10 Mar 2022 14:45:32 +0000 (UTC) X-FDA: 79228750104.18.8319C22 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf08.hostedemail.com (Postfix) with ESMTP id 80F33160013 for ; Thu, 10 Mar 2022 14:45:32 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id gj15-20020a17090b108f00b001bef86c67c1so5414856pjb.3 for ; Thu, 10 Mar 2022 06:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RPULJMtRKjA9XHVfCiU0lkTP5Po3/tVc3d3ybzr9pAI=; b=byClIQkE7K9xa0RUPSQIo8oicPjQHvO18luT1iFudeZHAwG/hmzPYRusS3SBg/y8Yz 4xha71rAYfjUyIW8SiJMR5OVAf4y75iDDx2BAHwi/2H0qMNBNfdYV1e1Sr1YDxwV1gxO e8aG5gKO45NmxNHTT9LGtYN22t9cPih2/dZJ66v69DdqrU8nrkmS+QFG8wVcplvrfnCP P5y8vEyEpFx1YEt/RT/wRxb1YPV63wRAHyXLmVqOSnZnXAzu+tlT+0SXrUHBfH6wlDhG 1RCZma7jOYDiqOAQz4L2xGjDP9YEDiIcyEG3YD2Xo0haSnLqkkmY5G7vPVowX4yvrdjS /ElA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RPULJMtRKjA9XHVfCiU0lkTP5Po3/tVc3d3ybzr9pAI=; b=qE4maS5gGB8BNJqOpkiwsQnQyZDyXCBYRWhIah6NTw0U3gJnk40vwMZ6QgPNFbClc7 FJjwb8FRcKH9xdk3oVUjjX31mi0U3CqYAVkn+MqSKRfiWZdtVpwWAjhMQQ43HMtLIW+w U/PGeYjluOutSziP2BxPSNFI6mNdZoYDylPRpvLukz7/mKNwRT2i08h4GmAMysvxAI3a zIcTcLr+nl2+zO3kv2rprJVzhsePoct2KnmWyIRkNt0zDV8LZNW2+Dgi/h7u6Fdjz75a 4QG9wz+LyEy4Do0HPLbjO3AM44PVgXucqZF0lNivZEbdr+h6YNkvna9wPQ3+2ybnRPtN N3HQ== X-Gm-Message-State: AOAM533thaqSrduOj8Gpkm6EmCOwQWbsIUcbO/5KNiddyA6vUoqYHNWS oIBiy3nS6LNwXw1c9Hvh8W0= X-Google-Smtp-Source: ABdhPJwZUmXQFM3Uvcfr5KMlb0Cc/uEttYBjsXg12377+TEKKxHNKSo5/XbJw4PSJO/SdlQluC6YNw== X-Received: by 2002:a17:902:e5cc:b0:151:f626:9153 with SMTP id u12-20020a170902e5cc00b00151f6269153mr5502607plf.41.1646923531533; Thu, 10 Mar 2022 06:45:31 -0800 (PST) Received: from odroid ([114.29.23.97]) by smtp.gmail.com with ESMTPSA id 1-20020a17090a1a0100b001bf3ba1508fsm6275329pjk.33.2022.03.10.06.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 06:45:31 -0800 (PST) Date: Thu, 10 Mar 2022 14:45:24 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: sxwjean@me.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, longman@redhat.com, guro@fb.com, willy@infradead.org, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH v2 2/2] mm: slub: Delete useless parameter of alloc_slab_page() Message-ID: <20220310144524.GA1166889@odroid> References: <20220310140701.87908-1-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220310140701.87908-1-sxwjean@me.com> X-Rspamd-Queue-Id: 80F33160013 X-Stat-Signature: obizijuxnbftcs48pcq8meyaakiqfbgc X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=byClIQkE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646923532-678959 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: Xiongwei Song > > The parameter @s is useless for alloc_slab_page(). It was added in 2014 > by commit 5dfb41750992 ("sl[au]b: charge slabs to kmemcg explicitly"). The > need for it was removed in 2020 by commit 1f3147b49d75 ("mm: slub: call > account_slab_page() after slab page initialization"). Let's delete it. > > [willy@infradead.org: Added detailed history of @s] > Signed-off-by: Xiongwei Song > Reviewed-by: Matthew Wilcox (Oracle) > Acked-by: David Rientjes > Reviewed-by: Roman Gushchin > --- > mm/slub.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 261474092e43..5d273ee04c43 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1788,8 +1788,8 @@ static void *setup_object(struct kmem_cache *s, struct slab *slab, > /* > * Slab allocation and freeing > */ > -static inline struct slab *alloc_slab_page(struct kmem_cache *s, > - gfp_t flags, int node, struct kmem_cache_order_objects oo) > +static inline struct slab *alloc_slab_page(gfp_t flags, int node, > + struct kmem_cache_order_objects oo) > { > struct folio *folio; > struct slab *slab; > @@ -1941,7 +1941,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min)) > alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL); > >- slab = alloc_slab_page(s, alloc_gfp, node, oo); >+ slab = alloc_slab_page(alloc_gfp, node, oo); > if (unlikely(!slab)) { > oo = s->min; > alloc_gfp = flags; >@@ -1949,7 +1949,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > * Allocation may have failed due to fragmentation. > * Try a lower order alloc if possible > */ >- slab = alloc_slab_page(s, alloc_gfp, node, oo); >+ slab = alloc_slab_page(alloc_gfp, node, oo); > if (unlikely(!slab)) > goto out; > stat(s, ORDER_FALLBACK); Looks good, nice changelog! Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>