From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: sxwjean@me.com
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
vbabka@suse.cz, longman@redhat.com, guro@fb.com,
willy@infradead.org, roman.gushchin@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH v2 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag
Date: Thu, 10 Mar 2022 14:27:47 +0000 [thread overview]
Message-ID: <20220310142747.GA1166219@odroid> (raw)
In-Reply-To: <20220310140701.87908-2-sxwjean@me.com>
On Thu, Mar 10, 2022 at 10:07:00PM +0800, sxwjean@me.com wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deleted all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.
>
Looks nice!
Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> Acked-by: David Rientjes <rientjes@google.com>
> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
> ---
> include/linux/slab.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 37bde99b74af..b6b3eed6c7c4 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -117,9 +117,6 @@
> #define SLAB_RECLAIM_ACCOUNT ((slab_flags_t __force)0x00020000U)
> #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */
>
> -/* Slab deactivation flag */
> -#define SLAB_DEACTIVATED ((slab_flags_t __force)0x10000000U)
> -
> /*
> * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests.
> *
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-03-10 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 14:06 [PATCH v2 0/2] Cleanups for slab sxwjean
2022-03-10 14:07 ` [PATCH v2 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag sxwjean
2022-03-10 14:27 ` Hyeonggon Yoo [this message]
2022-03-10 14:07 ` [PATCH v2 2/2] mm: slub: Delete useless parameter of alloc_slab_page() sxwjean
2022-03-10 14:45 ` Hyeonggon Yoo
2022-03-10 17:20 ` [PATCH v2 0/2] Cleanups for slab Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310142747.GA1166219@odroid \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox