From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E39EC433F5 for ; Thu, 10 Mar 2022 00:57:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1C7D8D0002; Wed, 9 Mar 2022 19:57:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCB388D0001; Wed, 9 Mar 2022 19:57:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B931F8D0002; Wed, 9 Mar 2022 19:57:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id ABD018D0001 for ; Wed, 9 Mar 2022 19:57:09 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 679868249980 for ; Thu, 10 Mar 2022 00:57:09 +0000 (UTC) X-FDA: 79226662578.17.F3E1A99 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf10.hostedemail.com (Postfix) with ESMTP id 56335C0012 for ; Thu, 10 Mar 2022 00:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646873828; x=1678409828; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EGCCGf78mu6c1NuKFEQ6fLhRTn1OWX4f7P2TPo065pc=; b=KMWJeyYJaR7nWkZ2y8Yq8K4g/DLR21QOjcy8LEEutiSs+JF4CuiCMpbO Vo9VoTwOz9s6IvihJ9t1Y7ym39jGIPS9c6x+k63zGCTO4fdMhNNc+17qM 4HFfot9hQvddRvRWRiSgSe12H9goyqNFp0Pvayig78r3Wpv9OkLaQXi15 VAm/Bgb5Oqle8ZWwkWXH5z5t6E4CnABBhc5GtfXH2JDP+pQ2H0DjMH/6O xz0U9GEm7VwxtVNrR3R3EXez25S6dZ/aUsRVSJmHH9LEyLIeCHq6QhCWB /eEF5F6/N4NU/fWkjUsiNE0U72FV8921HXS3O0Yy29nozrKG982vIT5Vg Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10281"; a="315844489" X-IronPort-AV: E=Sophos;i="5.90,169,1643702400"; d="scan'208";a="315844489" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2022 16:57:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,169,1643702400"; d="scan'208";a="642361390" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2022 16:57:04 -0800 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nS771-00045W-Fx; Thu, 10 Mar 2022 00:57:03 +0000 Date: Thu, 10 Mar 2022 08:56:30 +0800 From: kernel test robot To: Oscar Salvador , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , Dave Hansen , "Huang, Ying" , Abhishek Goel , linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node changes its N_CPU state Message-ID: <202203100830.iDtoMHKt-lkp@intel.com> References: <20220309144644.4278-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309144644.4278-1-osalvador@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 56335C0012 X-Stat-Signature: hj3brh7kthbw6hcb46tugzoz61k49rgf Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KMWJeyYJ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf10.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com X-HE-Tag: 1646873828-995078 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Oscar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707 base: https://github.com/hnaz/linux-mm master config: sparc-randconfig-r001-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100830.iDtoMHKt-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8af0c9ff9475c64e31963a5810b127875081c5ff git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Oscar-Salvador/mm-Only-re-generate-demotion-targets-when-a-numa-node-changes-its-N_CPU-state/20220309-224707 git checkout 8af0c9ff9475c64e31963a5810b127875081c5ff # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash kernel/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from kernel/sched/sched.h:53, from kernel/sched/core.c:13: include/linux/migrate.h:54:20: error: function declaration isn't a prototype [-Werror=strict-prototypes] 54 | static inline void set_migration_target_nodes() {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/migrate.h: In function 'set_migration_target_nodes': >> include/linux/migrate.h:54:20: warning: old-style function definition [-Wold-style-definition] kernel/sched/core.c: At top level: kernel/sched/core.c:3442:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes] 3442 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from kernel/sched/sched.h:53, from kernel/sched/loadavg.c:9: include/linux/migrate.h:54:20: error: function declaration isn't a prototype [-Werror=strict-prototypes] 54 | static inline void set_migration_target_nodes() {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/migrate.h: In function 'set_migration_target_nodes': >> include/linux/migrate.h:54:20: warning: old-style function definition [-Wold-style-definition] cc1: some warnings being treated as errors -- In file included from kernel/sched/sched.h:53, from kernel/sched/fair.c:23: include/linux/migrate.h:54:20: error: function declaration isn't a prototype [-Werror=strict-prototypes] 54 | static inline void set_migration_target_nodes() {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/migrate.h: In function 'set_migration_target_nodes': >> include/linux/migrate.h:54:20: warning: old-style function definition [-Wold-style-definition] kernel/sched/fair.c: At top level: kernel/sched/fair.c:11135:6: warning: no previous prototype for 'task_vruntime_update' [-Wmissing-prototypes] 11135 | void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi) | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from kernel/sched/sched.h:53, from kernel/sched/rt.c:6: include/linux/migrate.h:54:20: error: function declaration isn't a prototype [-Werror=strict-prototypes] 54 | static inline void set_migration_target_nodes() {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/migrate.h: In function 'set_migration_target_nodes': >> include/linux/migrate.h:54:20: warning: old-style function definition [-Wold-style-definition] kernel/sched/rt.c: At top level: kernel/sched/rt.c:730:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes] 730 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +54 include/linux/migrate.h 36 37 extern void migrate_page_states(struct page *newpage, struct page *page); 38 extern void migrate_page_copy(struct page *newpage, struct page *page); 39 extern int migrate_huge_page_move_mapping(struct address_space *mapping, 40 struct page *newpage, struct page *page); 41 extern int migrate_page_move_mapping(struct address_space *mapping, 42 struct page *newpage, struct page *page, int extra_count); 43 void migration_entry_wait_on_locked(swp_entry_t entry, pte_t *ptep, 44 spinlock_t *ptl); 45 void folio_migrate_flags(struct folio *newfolio, struct folio *folio); 46 void folio_migrate_copy(struct folio *newfolio, struct folio *folio); 47 int folio_migrate_mapping(struct address_space *mapping, 48 struct folio *newfolio, struct folio *folio, int extra_count); 49 50 extern bool numa_demotion_enabled; 51 #ifdef CONFIG_HOTPLUG_CPU 52 extern void set_migration_target_nodes(void); 53 #else > 54 static inline void set_migration_target_nodes() {} 55 #endif 56 #else 57 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org