From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC783C433F5 for ; Thu, 10 Mar 2022 01:38:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28DE28D0002; Wed, 9 Mar 2022 20:38:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23DAB8D0001; Wed, 9 Mar 2022 20:38:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105BD8D0002; Wed, 9 Mar 2022 20:38:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id F31078D0001 for ; Wed, 9 Mar 2022 20:38:50 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C65A12111B for ; Thu, 10 Mar 2022 01:38:50 +0000 (UTC) X-FDA: 79226767620.14.285D11D Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) by imf22.hostedemail.com (Postfix) with ESMTP id D31ABC0017 for ; Thu, 10 Mar 2022 01:38:48 +0000 (UTC) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-05 (Coremail) with SMTP id zQCowAD3JECYViliZyG6Ag--.65443S2; Thu, 10 Mar 2022 09:38:33 +0800 (CST) From: Jiasheng Jiang To: dan.carpenter@oracle.com Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org, broonie@kernel.org, Jiasheng Jiang Subject: Re: [linux-next:master 9388/11353] sound/soc/soc-compress.c:628 snd_soc_new_compress() error: we previously assumed 'codec_dai' could be null (see line 571) Date: Thu, 10 Mar 2022 09:38:30 +0800 Message-Id: <20220310013830.1142718-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowAD3JECYViliZyG6Ag--.65443S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jr1kGFyDCr13ur15Kr47CFg_yoW3AFX_uw 1rWwnFv34DJF47tw4j9F42krWkXF4xCrs8AF9aqFy7Gr1rA3WFyryDK393ZF4xXr4Dtrn0 vFn0qrWrAr17ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Rspamd-Queue-Id: D31ABC0017 X-Stat-Signature: 8q1i1u8aqk1w5guyyyyi8fb1648s1p6w X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of jiasheng@iscas.ac.cn designates 159.226.251.84 as permitted sender) smtp.mailfrom=jiasheng@iscas.ac.cn X-Rspamd-Server: rspam03 X-HE-Tag: 1646876328-221793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 18:18:23PM +0800, Dan Carpenter wrote: > Yeah. That's true. Smatch tries to look at conditions and figure out > the implications but this one is too complicated. > > But if codec_dai can really be NULL then it would be easier to > understand if we reversed the check on codec_dai and returned early. > > if (!codec_dai) { > dev_err(rtd->card->dev, "Missing codec\n"); > return -EINVAL; > } > > /* check client and interface hw capabilities */ > if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK) && > snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) > playback = 1; Thanks, it looks good to me. I will submit a patch with "Reported-by: Dan Carpenter " to make the code more clear. Jiang