From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD89C433F5 for ; Thu, 10 Mar 2022 01:13:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A23EB8D0002; Wed, 9 Mar 2022 20:13:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D2BC8D0001; Wed, 9 Mar 2022 20:13:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899EF8D0002; Wed, 9 Mar 2022 20:13:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 761E48D0001 for ; Wed, 9 Mar 2022 20:13:53 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 3564A6063D for ; Thu, 10 Mar 2022 01:13:53 +0000 (UTC) X-FDA: 79226704746.07.A5D8C9D Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf18.hostedemail.com (Postfix) with ESMTP id C92F01C0015 for ; Thu, 10 Mar 2022 01:13:52 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id qx21so8737547ejb.13 for ; Wed, 09 Mar 2022 17:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/HElp+aQtnErb8eqKq5xR1nF/Sumgv37cBYNTIU6bAQ=; b=jv/5PHwiHW0AZAumnhPrVNtgtPuklBFkA1hczMZa7ImunP5cCkSlc0r1Ui5FxO3Zv7 scs8NdWiYT1GF89qUej5glSFMcOpe5h3uI5+VpIiymJQ5lwIPDG6n23XuX2qHfw6pv9G D+zvAhStTgmlJbw/wYGRM4SshhrYtc2YEiENKzOT+TkTfWKRne3cSA/XO0cDsF30N2Kg B+vU6ydsPyKAdeswzLhPBYb3p8wIkTVbYQbLONhkUE74rRgm8vNngECUOOe6t9INblMo wQInb1uDdtGbUCjitYkQ94Q3BqM4vKObcHqwLuZXiVaHW87SAKJ6vjNkCbMBTQrQmLqy r7ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=/HElp+aQtnErb8eqKq5xR1nF/Sumgv37cBYNTIU6bAQ=; b=fGVy6gF1o9tU+JVTpl2te1U3x2LgYoox0CieWZetFQvZrvL3BMzoFoq4UiyUANG/of I4Y81Jqvjgqgq+AMt2b3DnrZlzjaYY+sHEhlcY4V8n1hRQMIxwZTGAsHO6fpR6shKNaZ Y4IqXZyHIhXKL72+LjezrySEl2rGMGAF8zOjR6k6LGhgFTRA2SMXC39hdA/3swQv7rry uGUhtDvrjCZRvqlS4JxyWS9ReW1kuRmjhX577BN0TnryDELf02XNoxJKIg5kT38WkjNo cAR0NtdiR/p1XJuncgD9pt9U+GRCwIEqtiaiTnyfZO7QDsmJhX387AFMqOwOZWc4y3AG ycEg== X-Gm-Message-State: AOAM532nImBqz0tTfcfwzkdqgBNRLJ1fz0Lo4rCOCN9OBhZn1HynDDQR tzyeVWpkmZnlZH9m90bSyhQ= X-Google-Smtp-Source: ABdhPJzvl/4eKnTouNNwFSWpvkmI6uOs+6dIlYUZWk20s54R0a5B4+YvHt2pkvBf4PMw7rjdfZD41Q== X-Received: by 2002:a17:907:eab:b0:6da:8ec5:d386 with SMTP id ho43-20020a1709070eab00b006da8ec5d386mr2179855ejc.668.1646874831369; Wed, 09 Mar 2022 17:13:51 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id y18-20020aa7ca12000000b0041677910461sm1422635eds.53.2022.03.09.17.13.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Mar 2022 17:13:50 -0800 (PST) Date: Thu, 10 Mar 2022 01:13:50 +0000 From: Wei Yang To: Michal Hocko Cc: Wei Yang , hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tim Chen Subject: Re: [PATCH 3/3] mm/memcg: add next_mz back if not reclaimed yet Message-ID: <20220310011350.2b6fxa66it5nugcy@master> Reply-To: Wei Yang References: <20220308012047.26638-1-richard.weiyang@gmail.com> <20220308012047.26638-3-richard.weiyang@gmail.com> <20220309004620.fgotfh4wsquscbfn@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: C92F01C0015 X-Stat-Signature: azpmiujy8tkhtxz43na3pfki6dhg33iz X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="jv/5PHwi"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646874832-656597 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 02:48:45PM +0100, Michal Hocko wrote: >[Cc Tim - the patch is http://lkml.kernel.org/r/20220308012047.26638-3-richard.weiyang@gmail.com] > >On Wed 09-03-22 00:46:20, Wei Yang wrote: >> On Tue, Mar 08, 2022 at 09:17:58AM +0100, Michal Hocko wrote: >> >On Tue 08-03-22 01:20:47, Wei Yang wrote: >> >> next_mz is removed from rb_tree, let's add it back if no reclaim has >> >> been tried. >> > >> >Could you elaborate more why we need/want this? >> > >> >> Per my understanding, we add back the right most node even reclaim makes no >> progress, so it is reasonable to add back a node if we didn't get a chance to >> do reclaim on it. > >Your patch sounded familiar and I can remember now. The same fix has >been posted by Tim last year >https://lore.kernel.org/linux-mm/8d35206601ccf0e1fe021d24405b2a0c2f4e052f.1613584277.git.tim.c.chen@linux.intel.com/ >It was posted with other changes to the soft limit code which I didn't >like but I have acked this particular one. Not sure what has happened >with it afterwards. Because of this ? 4f09feb8bf: vm-scalability.throughput -4.3% regression https://lore.kernel.org/linux-mm/20210302062521.GB23892@xsang-OptiPlex-9020/ >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me