From: sxwjean@me.com
To: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
vbabka@suse.cz, longman@redhat.com, guro@fb.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page()
Date: Wed, 9 Mar 2022 22:50:52 +0800 [thread overview]
Message-ID: <20220309145052.219138-3-sxwjean@me.com> (raw)
In-Reply-To: <20220309145052.219138-1-sxwjean@me.com>
From: Xiongwei Song <sxwjean@gmail.com>
The parameter @s is useless for alloc_slab_page(), let's delete it.
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
mm/slub.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 261474092e43..5d273ee04c43 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1788,8 +1788,8 @@ static void *setup_object(struct kmem_cache *s, struct slab *slab,
/*
* Slab allocation and freeing
*/
-static inline struct slab *alloc_slab_page(struct kmem_cache *s,
- gfp_t flags, int node, struct kmem_cache_order_objects oo)
+static inline struct slab *alloc_slab_page(gfp_t flags, int node,
+ struct kmem_cache_order_objects oo)
{
struct folio *folio;
struct slab *slab;
@@ -1941,7 +1941,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min))
alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL);
- slab = alloc_slab_page(s, alloc_gfp, node, oo);
+ slab = alloc_slab_page(alloc_gfp, node, oo);
if (unlikely(!slab)) {
oo = s->min;
alloc_gfp = flags;
@@ -1949,7 +1949,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node)
* Allocation may have failed due to fragmentation.
* Try a lower order alloc if possible
*/
- slab = alloc_slab_page(s, alloc_gfp, node, oo);
+ slab = alloc_slab_page(alloc_gfp, node, oo);
if (unlikely(!slab))
goto out;
stat(s, ORDER_FALLBACK);
--
2.30.2
next prev parent reply other threads:[~2022-03-09 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:50 [PATCH 0/2] Cleanups for slab sxwjean
2022-03-09 14:50 ` [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag sxwjean
2022-03-09 17:14 ` David Rientjes
2022-03-10 1:18 ` Xiongwei Song
2022-03-10 1:49 ` Roman Gushchin
2022-03-09 14:50 ` sxwjean [this message]
2022-03-09 15:28 ` [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() Matthew Wilcox
2022-03-09 17:15 ` David Rientjes
2022-03-10 1:18 ` Xiongwei Song
2022-03-10 1:17 ` Xiongwei Song
2022-03-10 1:48 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309145052.219138-3-sxwjean@me.com \
--to=sxwjean@me.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sxwjean@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox