From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA93C433EF for ; Wed, 9 Mar 2022 21:45:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E6688D0002; Wed, 9 Mar 2022 16:45:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 694A38D0001; Wed, 9 Mar 2022 16:45:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C968D0002; Wed, 9 Mar 2022 16:45:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 441398D0001 for ; Wed, 9 Mar 2022 16:45:59 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F2D70A0A05 for ; Wed, 9 Mar 2022 21:45:58 +0000 (UTC) X-FDA: 79226180838.21.0F6B2C9 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 670D24000F for ; Wed, 9 Mar 2022 21:45:58 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so3477813pjl.4 for ; Wed, 09 Mar 2022 13:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mPFui/TC4p7dUMGtLGBbKQqrKx8zpb9vShIPpsPuML0=; b=FmgcSQxVPwrzTwKji9hdLnY25RfMT5VN3wweJFejAkZ0PU/llBS2Mj92/mxkiD0k1Q fGqieS5x/sut7UaTSPDGpdEbZo5tqk1bGBuzatPFg669/ifbTvo/Nq6qKJ4wT1LpzFKD BtkmHn44ujtA5JrEtYiB96ImpO3jN3BKxPUT0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mPFui/TC4p7dUMGtLGBbKQqrKx8zpb9vShIPpsPuML0=; b=lC2FSqAKQ1id1GmRwHE/JxIp6bhdTIdgDT5KJlWhjm3bRtWQzKo/9Wslebfo6urQ3r /qONeRqmV+xUm30+2Qvwkzbjphn6Lwuck9psZ2XWnMUD7ONnqFCY/RifcwLw4ZrxzA7a T2Go3K3YP4AdCmxkM6Yz4p2+hKTZ7rSm380FzHuIJxbqF1n88rWHQt5IZHDCxKdThW7k 9gB8U7ZdE537fEka46arHIHlahw0nNrJcTElrglD+2kCUC04Iw87jtdUUp7mIy83t/mv BANj033xy6Ll3H3zZyAcJTHf689bW2rByW+8Dmh8leCfHtP3evZXAa45FH2VwuX+y+1t r/1Q== X-Gm-Message-State: AOAM5332On+wCb/OuZmkmNMg1UgMAyzk65gXHlq5khSzgslGJHs7uthl fY3JDYoPuCYO8K/GshyN2Z1TmQ== X-Google-Smtp-Source: ABdhPJwDRr6oG/QAYJFcQdhhQndZU1FMOLkHHmjqOI2A1WXaXvUT/5Af1bNdMhR36WjvO4tYRhinzw== X-Received: by 2002:a17:903:4a:b0:151:be09:3de9 with SMTP id l10-20020a170903004a00b00151be093de9mr1624286pla.138.1646862357242; Wed, 09 Mar 2022 13:45:57 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h6-20020a636c06000000b00363a2533b17sm3247890pgc.8.2022.03.09.13.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 13:45:56 -0800 (PST) Date: Wed, 9 Mar 2022 13:45:56 -0800 From: Kees Cook To: "Eric W. Biederman" Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , Denys Vlasenko , Vlastimil Babka , "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org Subject: Re: [GIT PULL] Fix fill_files_note Message-ID: <202203091345.3755C2B5@keescook> References: <877dafq3bw.fsf@email.froward.int.ebiederm.org> <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> <87h788fdaw.fsf_-_@email.froward.int.ebiederm.org> <202203081342.1924AD9@keescook> <877d93dr8p.fsf@email.froward.int.ebiederm.org> <202203090830.7E971BD6C@keescook> <8735jqdg84.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735jqdg84.fsf@email.froward.int.ebiederm.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 670D24000F X-Stat-Signature: 8n65dkfj8awxkj3wdyy9i1m5zt8r6utg Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FmgcSQxV; spf=pass (imf17.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1646862358-468335 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 02:27:07PM -0600, Eric W. Biederman wrote: > It turns out I missed a crazy corner case of binfmt_flat, when coredumps > are disabled. This fixes a compile error that was reported. > > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git coredump-vma-snapshot-fix-for-v5.18 > HEAD: f833116ad2c3eabf9c739946170e07825cca67ed coredump: Don't compile flat_core_dump when coredumps are disabled > > Can you include this as well. Thanks! Pulled and pushed out. -- Kees Cook