From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: linux-mm@kvack.org, Mike Kravetz <mike.kravetz@oracle.com>,
Miaohe Lin <linmiaohe@huawei.com>, Yang Shi <shy828301@gmail.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mm/hwpoison: set PageHWPoison after taking page lock in memory_failure_hugetlb()
Date: Wed, 9 Mar 2022 13:30:10 -0800 [thread overview]
Message-ID: <20220309133010.0f04c2ac4939edbdb35723bb@linux-foundation.org> (raw)
In-Reply-To: <20220309091449.2753904-1-naoya.horiguchi@linux.dev>
On Wed, 9 Mar 2022 18:14:49 +0900 Naoya Horiguchi <naoya.horiguchi@linux.dev> wrote:
> There is a race condition between memory_failure_hugetlb() and hugetlb
> free/demotion, which causes setting PageHWPoison flag on the wrong page
> (which was a hugetlb when memory_failrue() was called, but was removed
> or demoted when memory_failure_hugetlb() is called). This results in
> killing wrong processes. So set PageHWPoison flag with holding page lock,
What are the runtime effects of this? Do we think a -stable backport
is needed?
Are we missing a reported-by here? I'm too lazy to hunt down who it was.
next prev parent reply other threads:[~2022-03-09 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 9:14 Naoya Horiguchi
2022-03-09 21:30 ` Andrew Morton [this message]
2022-03-10 1:15 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-09 21:55 ` Yang Shi
2022-03-09 23:59 ` Mike Kravetz
2022-03-10 0:29 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-10 0:00 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-10 0:30 ` Yang Shi
2022-03-10 6:23 ` Miaohe Lin
2022-03-10 17:50 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309133010.0f04c2ac4939edbdb35723bb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox