From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AB7C433EF for ; Wed, 9 Mar 2022 10:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9C168D0005; Wed, 9 Mar 2022 05:19:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B148D0001; Wed, 9 Mar 2022 05:19:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEC0F8D0005; Wed, 9 Mar 2022 05:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id AD12F8D0001 for ; Wed, 9 Mar 2022 05:19:12 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7AA4360C09 for ; Wed, 9 Mar 2022 10:19:12 +0000 (UTC) X-FDA: 79224450144.12.EB7EAD1 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf31.hostedemail.com (Postfix) with ESMTP id C7DA92000D for ; Wed, 9 Mar 2022 10:19:11 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22988WaD003117; Wed, 9 Mar 2022 10:18:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=GpvkTDjDXYncm4OooN0F/FKVz/IFVKD/qg4aPxhACdY=; b=qvq1Sa4hRyRbpmHaOIVwngtSQtvMIjH90J3nYdXrd78qJRTHoAW0e8vSCi4kCHfwdtp4 bXHBh9Wu/eb4FIzWshR4Hfj4Z3Tpp4tAaQPfHBCOpuTdO/Tu0dtnyP4m9NEaZsBSGwZS PmN6XbJ3TpCIMEHgUuCaM/kVw5rDQBw4QTV82J7+F0O1sUhLfTIxVu7U1kTiViarD2hZ LahnmyMKQd1myEAaBNs5vEEszevQvS+yehE5hxXUhc0eK9cCG86vTO8WId9x7qX5cxyR qjJw0ccIqQ887CiraYyBy9P2HU1cJfXLxoIqmhpwp9nTizj4krj1wPX5aYmtyFtEIdY9 fw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3em0du1qx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Mar 2022 10:18:45 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 229AFvZ7063118; Wed, 9 Mar 2022 10:18:43 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by userp3020.oracle.com with ESMTP id 3envvmckqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Mar 2022 10:18:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fRiwWMku1iFSzjJxJTMgWw3VkDqzUbgE4t8+woioOr/HlG/bmku4bhvUraTEU/H9R+z6r9V+pUuUJXO8Ead9KZMDgQ+JUpAiMClouRFI/ydMILxd/kkA8fi58hZ85wH3pWY/G37WYToCm61oXk2oSZML/K8sXoopBzVMsKljNxTQjbo8pUo9kNW9AfmSih753uGsprVM3dbovsQ/CAPdV7WxMAYaNrzFwnT6hUjlU2gbJFBR8vpLImzDPBvWmigc3UJ6QDJHoyTzb5FBLPKiWf0kVlvLfdv+V5jtSsOj0+/O7MZWruFwgwTEna/QWgRm/onp/Y0+JXCabOM3KRGWhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GpvkTDjDXYncm4OooN0F/FKVz/IFVKD/qg4aPxhACdY=; b=OH6SbaIb0Xk/0xgZkUz0K8/ynktD2vD1EHKpTO+mcC99hjIAH5Rb74bFO6vAZo5E8vYWLPK3EkyT7B7feCS58MyKhH+ZoPUln2ppRxaPLxLDGfTCjzzCIxxp3J55Nm67rXVi50+UyoJtPZlomNtRJb+gYCj+ssLeKJ+7SXe7in4v8/VEhQbQW5VN3jrqKInoeqo5iWZs5GkVSEOkeVsgpjin03QNj07PvCyO3bAUGwCKxiL0fdPz11H4KVZ4G9XmTZCmuhTeCBl8an5i0jxDd92m/Q9w85N2cJLRKAb5yT6NWceRfwga6Jh8w1pEwezN7dqEMtqF8qofQu8HoWudfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GpvkTDjDXYncm4OooN0F/FKVz/IFVKD/qg4aPxhACdY=; b=wyunVNQ4Gew11D8ZY1IKHgEPeGmU0YU3xXBbBcFZYMeDRcrM7yN7OUbTa2tX1zBEYtFy6M6ZCElQQUIwO4w3nIFVICvysGwos3G00A44QYxJrSdejUJ8y+dfkRd6zw+FCQJVqGBtLK1mViuYNdjo0EeOAH/6B3+qDf18pfd8z4k= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MN2PR10MB3246.namprd10.prod.outlook.com (2603:10b6:208:122::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Wed, 9 Mar 2022 10:18:41 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5038.026; Wed, 9 Mar 2022 10:18:41 +0000 Date: Wed, 9 Mar 2022 13:18:23 +0300 From: Dan Carpenter To: Jiasheng Jiang Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org, broonie@kernel.org Subject: Re: [linux-next:master 9388/11353] sound/soc/soc-compress.c:628 snd_soc_new_compress() error: we previously assumed 'codec_dai' could be null (see line 571) Message-ID: <20220309101823.GS3315@kadam> References: <20220309093219.1142599-1-jiasheng@iscas.ac.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309093219.1142599-1-jiasheng@iscas.ac.cn> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNAP275CA0064.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::20) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd078be4-a225-4af2-363b-08da01b62f02 X-MS-TrafficTypeDiagnostic: MN2PR10MB3246:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SUUCuPCwkfkWLjtTtylJKXyI5NmYuQ1hcHL4VCgyBSnQ+PGyOYwWxQnz3dZXip6xaWJwVUTlRjMrVWGqvMxqv3YVRoEgHPYus1d72Ybqt7oFcDDi00+cx143Pyw0wpgEFkXv4xhDXTCw5xKpoWGP2vCHgUV9aFdUFWkxyfflGmeWYXRAnYyIgyLnpSbmKe/rIMrnkd6hd0Ph/OFp7Z98oOU5Oo1F4N4mVVB/BXFoG5X6fNR6QeCDOKxWtsgCGBZaVwSS9OrcgU6Rj4v0JyKQVyQ+luO5jIqR3P+x7WlC93cE+x+ARqVzEc4cwG/ca5lYJzVaRt6UeqA6mcEolfTLIZWB/F/O3jnLIv67FkzIkXOzUhcHTtKShyjhUt6lT9ti7ntpS8b3zMnN0aLzkTGIo11lcB4efdC1stqQz7lFgbONqeZR8JIJFBL6RPqbnOOZqWF+5jtLPByMvfN/jszm+a/zR1aX2xq8qkmJMirq365VN2lVer62ReVbuSpB9jQGjqpTg3CWvn4zcSS59OCD3x7Aoj26Zdg/UpcOk6bi2vQFJQFlcA3Rm38Z2rSnk4vbB6/7p38b3GspT6t9d1ifTv8uuB9lG5kbH4EwEnGepYDM8we94/OJMUNaRwm32oI2di6+8kcAVwtlFXoHDGljqKqgWfP7t/lwEhtiGlF+bjpdMG9YdoGASGfrK7vRjHDrAqL47/+YMkI+n++2PHckQTRS0uAIF667prk9AIHrGcnai+/kTC2OYE4mcae2/OE4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(8676002)(4001150100001)(66476007)(66556008)(66946007)(83380400001)(33656002)(5660300002)(4326008)(44832011)(6916009)(6486002)(86362001)(316002)(33716001)(2906002)(8936002)(508600001)(38350700002)(6666004)(6506007)(9686003)(52116002)(26005)(186003)(38100700002)(6512007)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aLQUFn06FBE+qJJXxUylrIAyQb1qOJA0lBwYprMHFz81h4YvLKYF1l+tppRg?= =?us-ascii?Q?w1cGSBij//QsBixX4jSdifcUCNaxT44ZjEZHSr+2HQUvZj4OEZp/u/Y+gNQF?= =?us-ascii?Q?h7XbGZ6cicyGecjQF+LRMoAbhOhEUdcVfh1if+ievu1bjllGQG4kKnjpDCA4?= =?us-ascii?Q?ka5jRYkO9sEPhCcWtSQlbTQLdPfZelx14NkbfZuMuBO8FWyLiQLdVqYAs16n?= =?us-ascii?Q?XuI3pT9IX/mzJhr92hPK52EETWy9ayKR6ztoPGMUHDr0oL60AWg09u47HrDf?= =?us-ascii?Q?wBj3T22bOwPaJCgfTlBD7+ZgB2wnTRu0vxDAA/HlrR9NbEDpIyrveAafs4NS?= =?us-ascii?Q?rXNbv5R6ER6dSueWufnMmh5xVOAzwF6ODdrRTWocfkhJ7JfF7MaekkEPmg44?= =?us-ascii?Q?6P5ZB0Jstp6cHFkA5dVv0gX3vDmYX7f2IrNLf16DMwytE56QA4W3vHKrGsBb?= =?us-ascii?Q?zdC3C8vrIhPV/17JdBGrlDYKqOZjQxChkpvxL7rU+TBFb1KC1QcImprKt980?= =?us-ascii?Q?phaA/XLJe/io3kWv2sGSh8lDhfM+oNUvipjnJM9zr06viY5TzeUl1ZupeSZR?= =?us-ascii?Q?sX6nJL+guuhwwGpgY4HyHrByCngz16uK484eQ13tBEZzrX1IxRK3dOUQceAi?= =?us-ascii?Q?dKun6BstLnRm1ZItoUmEInKRnXMbLDX+GEuOhMCimZDmztN8uKgbwRgcRU0e?= =?us-ascii?Q?ILvs5ffu/S26maLTXX897SNXU0eBeBk1OxnP2/GtxIQHYts1xVdJbWwkF1Za?= =?us-ascii?Q?jB6VmXDnmoDNTuEIzwLLFvhRmE+0RwgaYSGmTrOspMZ7kdhdDbgv3giZ9cS6?= =?us-ascii?Q?C/LuYZD5K7rzw2EgJpQD/0Pe3tMwLE8b6RJ+dli+yr4ZhEjeVsARvi+J3vz7?= =?us-ascii?Q?t1cCaptATvGMgnN7v1WDz3jJs3lIya1Q+njOnedY+sCXMvRNwUagk5sdDoFy?= =?us-ascii?Q?oieT4PuB+cp2MF6kw6IYNOz8bclMtAiacMCSEQfWGXO2zDcJn9G8ihJbhM3h?= =?us-ascii?Q?9R8syW9Cu/1lHbv3gp0oVj6gxmStsvIxJc2BdIs6xNKK8Hq7H1Hw2ChLJ+dX?= =?us-ascii?Q?jpscaTb9FUmnd5ObuRXk0QAR9upSymVplbIm8CtUWbcTuYvC5XF2HfRT6tWH?= =?us-ascii?Q?QLJZYPY+vW7MRUHFbIVM2cYnEMrJ+CHLFEEW0RX6LZWvx69SGVlXuASL/x6z?= =?us-ascii?Q?+dbzLX/0A8WM7ThwZDMWzvRzIUUlPoB0oDtnaB00L9bO9bjqOv6A918Vr95/?= =?us-ascii?Q?MW29rgCl/Ho9wQZxeL9gWoHRjmd6spPQk/0VlTNN2fBsKn5b/aZaNzfr/k4G?= =?us-ascii?Q?BMTCWsxYNH4hnz/BMysrM1MOyp1pTLhVXJG9ro7kOaT2OTYFQ7cTkVsUf0gQ?= =?us-ascii?Q?W3o2u1EcLhPO6GLwh7ZoXC5WfxvOqIBvzu+0Fa7F1bsjWREyyAhzzB6uw6b3?= =?us-ascii?Q?NtlENNhadeUw0Z89Vo141u/gXJNNMOryiueuYAIJ8aY3DstWX3WberqPyghh?= =?us-ascii?Q?OPgJDyqWUEXBDz+pNHZL3GeWNm7Yvrzq2P/cx3AcTbWxHdT5BapxlGg+VAqq?= =?us-ascii?Q?ba2Q9ZS130GEdsQzHkp3KjmoMCgK8WTaNY58+NCvcEa1GsD+GJoi69Y0oa7L?= =?us-ascii?Q?AtYJcK9fCxoAd4SkIW05N1KBDJmWyE4QPzVxA3eokdHcdmnj3AXHpWhLBKP+?= =?us-ascii?Q?wDhy2g=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd078be4-a225-4af2-363b-08da01b62f02 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 10:18:41.2102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3pg4cX6/gVxmA2+D/81CXOUKpVCFbNeyzX/6BvjYm1i8rZu+idmgc5VxnxGIjJaZ0dV7BRgzN3ADpuuYh1ET/S00LCn4X347MdRawf/qDvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3246 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10280 signatures=690848 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=819 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203090056 X-Proofpoint-ORIG-GUID: 6zqRnxvHZqFMPweb8c7DZGN1YFl7Z7rN X-Proofpoint-GUID: 6zqRnxvHZqFMPweb8c7DZGN1YFl7Z7rN X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C7DA92000D X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=qvq1Sa4h; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wyunVNQ4; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf31.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: cnhoiwz1tktzohz3ifynruag6upzkick X-HE-Tag: 1646821151-141577 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000135, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 05:32:19PM +0800, Jiasheng Jiang wrote: > On Wed, Mar 09, 2022 at 01:58:04AM +0800, Dan Carpenter wrote: > > smatch warnings: > > sound/soc/soc-compress.c:628 snd_soc_new_compress() error: we previously assumed 'codec_dai' could be null (see line 571) > > > de2c6f98817fa5d Jiasheng Jiang 2021-10-15 @571 if (codec_dai) { > > > > Can codec_dai be NULL? This new code assumes so. > > > aeb6fa0f15c71a1 Peng Donglin 2017-08-16 @628 rtd->dai_link->stream_name, codec_dai->name, num); > > ^^^^^^^^^^^^^^^^ > > Unchecked dereference > > Actually, if 'codec_dai' is NULL, the check in line 584 will fail and return -EINVAL. > > a1068045883ed4a Vinod Koul 2016-01-07 584 if (playback + capture != 1) { > 141dfc9e3751f5f Charles Keepax 2018-01-26 585 dev_err(rtd->card->dev, > 141dfc9e3751f5f Charles Keepax 2018-01-26 586 "Compress ASoC: Invalid direction for P %d, C %d\n", > a1068045883ed4a Vinod Koul 2016-01-07 587 playback, capture); > a1068045883ed4a Vinod Koul 2016-01-07 588 return -EINVAL; > a1068045883ed4a Vinod Koul 2016-01-07 589 } > Yeah. That's true. Smatch tries to look at conditions and figure out the implications but this one is too complicated. But if codec_dai can really be NULL then it would be easier to understand if we reversed the check on codec_dai and returned early. if (!codec_dai) { dev_err(rtd->card->dev, "Missing codec\n"); return -EINVAL; } /* check client and interface hw capabilities */ if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK) && snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) playback = 1; regards, dan carpenter