From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19142C433EF for ; Wed, 9 Mar 2022 09:55:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7254E8D0028; Wed, 9 Mar 2022 04:55:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D52B8D0001; Wed, 9 Mar 2022 04:55:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4448D0028; Wed, 9 Mar 2022 04:55:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 4ED188D0001 for ; Wed, 9 Mar 2022 04:55:31 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0736B8249980 for ; Wed, 9 Mar 2022 09:55:31 +0000 (UTC) X-FDA: 79224390462.17.7F04AB5 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf13.hostedemail.com (Postfix) with ESMTP id 2F0BF20012 for ; Wed, 9 Mar 2022 09:55:29 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id ge19-20020a17090b0e1300b001bcca16e2e7so4736397pjb.3 for ; Wed, 09 Mar 2022 01:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XGPvmym07bxizPlaV93boc4dRxyZrMMzOC0ov2cO4E8=; b=PpMnduGy3C4sqc7UhVaFiGOKydHZz/v0e1jqKRqRBW58P70y3O4m039ZVfIRyTNvZX +TB+2MS6e4FoAswNPEK1xFzStl95L8PaE1Lx+75nPlz86R9arQAhhykMFfMos59OXNFM acRfxqv4NxxULe4Sq7MDEUEXjCEu/Dg+lBicV+8lqhSskautuCfEFGD4aaYWLXfxo7Qt 0Tr2QR0/hz79N70Jetk/YqY6Tmg50c0Dasuc2os4en+nzNKQ4KDsWBzG+ZBONh4C+52s mfPPxgSh3oY53a8XDmGkXZUS9dSi2Tjc33UOVZxh5byp8lrXbXF4aHRWLWx9oW2NNdZC j3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XGPvmym07bxizPlaV93boc4dRxyZrMMzOC0ov2cO4E8=; b=BKwUKX85jQRgVCD0wGDh52tdLG+hX3wR4PJJYon2BfyaG0hUbqiuwu43uPfmYmKqr6 EEqpQGr5EiKUPRKdLee4pnB8wJStTeMtCeDxTlfBA11+Tzg84SQZ342Mcpay3MyAarng sWzAM12w06A4hjZAtpMTHIZFWLOP9qB3/LODCy0MJfke2sgtlYZYLchAWqhpcVYJ0WrD rfUruxbiroGx/XDHXfFSNQCFIrlqlkDG+KkqrOzUvFvBscwATHA8BI2MYtnRg4+qgh6D qAr1yrLZMyLDmyKVmsAAARkdLw1zyUGKbm+mIkzlV5qrqS99eWg+HICbby0iDGPL4YpV 7O4w== X-Gm-Message-State: AOAM533j18bGBDSmbv1yKfoPoGfJwyY9b0y0QL6NLEbH5WjEl9nlKp8V BMWmpD7Nkt8YBCEhaLZ3QKM= X-Google-Smtp-Source: ABdhPJyyqpvPYZqnrlWYWmMNqi8qbWejB4dUpdV8zy/7cd0orIl1ARVmxXBEx8nmmCL7oNCN/KoVTg== X-Received: by 2002:a17:902:c745:b0:153:b0e:8586 with SMTP id q5-20020a170902c74500b001530b0e8586mr617759plq.9.1646819728752; Wed, 09 Mar 2022 01:55:28 -0800 (PST) Received: from odroid ([114.29.23.97]) by smtp.gmail.com with ESMTPSA id c18-20020a056a000ad200b004f0f9696578sm2391939pfl.141.2022.03.09.01.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 01:55:28 -0800 (PST) Date: Wed, 9 Mar 2022 09:55:22 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Miaohe Lin Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove forced_order parameter in calculate_sizes Message-ID: <20220309095522.GA1091946@odroid> References: <20220309092036.50844-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309092036.50844-1-linmiaohe@huawei.com> X-Rspamd-Queue-Id: 2F0BF20012 X-Stat-Signature: 694wqtequspjw89yxkakx9o4y13uxo94 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PpMnduGy; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646819729-235321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 05:20:36PM +0800, Miaohe Lin wrote: > Since commit 32a6f409b693 ("mm, slub: remove runtime allocation order > changes"), forced_order is always -1. Remove this unneeded parameter > to simplify the code. > > Signed-off-by: Miaohe Lin > --- > mm/slub.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 180354d7e741..7f09901ae6b2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4038,7 +4038,7 @@ static void set_cpu_partial(struct kmem_cache *s) > * calculate_sizes() determines the order and the distribution of data within > * a slab object. > */ > -static int calculate_sizes(struct kmem_cache *s, int forced_order) > +static int calculate_sizes(struct kmem_cache *s) > { > slab_flags_t flags = s->flags; > unsigned int size = s->object_size; > @@ -4142,10 +4142,7 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order) > size = ALIGN(size, s->align); > s->size = size; > s->reciprocal_size = reciprocal_value(size); > - if (forced_order >= 0) > - order = forced_order; > - else > - order = calculate_order(size); > + order = calculate_order(size); > > if ((int)order < 0) > return 0; > @@ -4181,7 +4178,7 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) > s->random = get_random_long(); > #endif > > - if (!calculate_sizes(s, -1)) > + if (!calculate_sizes(s)) > goto error; > if (disable_higher_order_debug) { > /* > @@ -4191,7 +4188,7 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) > if (get_order(s->size) > get_order(s->object_size)) { > s->flags &= ~DEBUG_METADATA_FLAGS; > s->offset = 0; > - if (!calculate_sizes(s, -1)) > + if (!calculate_sizes(s)) > goto error; > } > } Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > -- > 2.23.0 -- Thank you, You are awesome! Hyeonggon :-)