From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB0DC433EF for ; Wed, 9 Mar 2022 09:32:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1BA8D0027; Wed, 9 Mar 2022 04:32:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A70618D0001; Wed, 9 Mar 2022 04:32:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95F838D0027; Wed, 9 Mar 2022 04:32:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 842368D0001 for ; Wed, 9 Mar 2022 04:32:38 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 40DFD6027D for ; Wed, 9 Mar 2022 09:32:38 +0000 (UTC) X-FDA: 79224332796.08.7FA0BBA Received: from cstnet.cn (smtp23.cstnet.cn [159.226.251.23]) by imf02.hostedemail.com (Postfix) with ESMTP id 9381580014 for ; Wed, 9 Mar 2022 09:32:36 +0000 (UTC) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-03 (Coremail) with SMTP id rQCowAAHKJkkdChi8GcxAg--.61455S2; Wed, 09 Mar 2022 17:32:21 +0800 (CST) From: Jiasheng Jiang To: dan.carpenter@oracle.com, kbuild@lists.01.org Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-mm@kvack.org, broonie@kernel.org, Jiasheng Jiang Subject: Re: [linux-next:master 9388/11353] sound/soc/soc-compress.c:628 snd_soc_new_compress() error: we previously assumed 'codec_dai' could be null (see line 571) Date: Wed, 9 Mar 2022 17:32:19 +0800 Message-Id: <20220309093219.1142599-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowAAHKJkkdChi8GcxAg--.61455S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr4rKr4xXw45Gr1UZw15XFb_yoWDArc_Zw sYq3sayryUXrs7uanFgrWa9wnFyr409rsIq3ZIgFnrZFyfXw15Cr9I9wn5CFy3JrnFyw13 Ar90gF4DZr17WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbwAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48J MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4 v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUdHUDUUUUU= X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Rspamd-Queue-Id: 9381580014 X-Stat-Signature: n9wyiaha889zuhndyfs8z88t4oyq5554 Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of jiasheng@iscas.ac.cn designates 159.226.251.23 as permitted sender) smtp.mailfrom=jiasheng@iscas.ac.cn; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646818356-305403 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 09, 2022 at 01:58:04AM +0800, Dan Carpenter wrote: > smatch warnings: > sound/soc/soc-compress.c:628 snd_soc_new_compress() error: we previously assumed 'codec_dai' could be null (see line 571) > de2c6f98817fa5d Jiasheng Jiang 2021-10-15 @571 if (codec_dai) { > > Can codec_dai be NULL? This new code assumes so. > aeb6fa0f15c71a1 Peng Donglin 2017-08-16 @628 rtd->dai_link->stream_name, codec_dai->name, num); > ^^^^^^^^^^^^^^^^ > Unchecked dereference Actually, if 'codec_dai' is NULL, the check in line 584 will fail and return -EINVAL. a1068045883ed4a Vinod Koul 2016-01-07 584 if (playback + capture != 1) { 141dfc9e3751f5f Charles Keepax 2018-01-26 585 dev_err(rtd->card->dev, 141dfc9e3751f5f Charles Keepax 2018-01-26 586 "Compress ASoC: Invalid direction for P %d, C %d\n", a1068045883ed4a Vinod Koul 2016-01-07 587 playback, capture); a1068045883ed4a Vinod Koul 2016-01-07 588 return -EINVAL; a1068045883ed4a Vinod Koul 2016-01-07 589 } Thanks, Jiang