linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Miles Chen <miles.chen@mediatek.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Chun-Jie Chen <chun-jie.chen@mediatek.com>
Subject: [linux-next:master 5968/11353] drivers/clk/mediatek/clk-pll.c:418:23: warning: variable 'base' set but not used
Date: Wed, 9 Mar 2022 07:41:03 +0800	[thread overview]
Message-ID: <202203090714.kf7arAXf-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   cb153b68ff91cbc434f3de70ac549e110543e1bb
commit: 6dd199064dd86127030b5bc59d4058370b6c8310 [5968/11353] clk: mediatek: pll: Implement unregister API
config: sh-randconfig-r002-20220308 (https://download.01.org/0day-ci/archive/20220309/202203090714.kf7arAXf-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=6dd199064dd86127030b5bc59d4058370b6c8310
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 6dd199064dd86127030b5bc59d4058370b6c8310
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/clk/mediatek/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/clk/mediatek/clk-pll.c: In function 'mtk_clk_unregister_plls':
>> drivers/clk/mediatek/clk-pll.c:418:23: warning: variable 'base' set but not used [-Wunused-but-set-variable]
     418 |         __iomem void *base = NULL;
         |                       ^~~~


vim +/base +418 drivers/clk/mediatek/clk-pll.c

   414	
   415	void mtk_clk_unregister_plls(const struct mtk_pll_data *plls, int num_plls,
   416				     struct clk_onecell_data *clk_data)
   417	{
 > 418		__iomem void *base = NULL;
   419		int i;
   420	
   421		if (!clk_data)
   422			return;
   423	
   424		for (i = num_plls; i > 0; i--) {
   425			const struct mtk_pll_data *pll = &plls[i - 1];
   426	
   427			if (IS_ERR_OR_NULL(clk_data->clks[pll->id]))
   428				continue;
   429	
   430			/*
   431			 * This is quite ugly but unfortunately the clks don't have
   432			 * any device tied to them, so there's no place to store the
   433			 * pointer to the I/O region base address. We have to fetch
   434			 * it from one of the registered clks.
   435			 */
   436			base = mtk_clk_pll_get_base(clk_data->clks[pll->id], pll);
   437	
   438			mtk_clk_unregister_pll(clk_data->clks[pll->id]);
   439			clk_data->clks[pll->id] = ERR_PTR(-ENOENT);
   440		}
   441	
   442		iounmap(base);
   443	}
   444	EXPORT_SYMBOL_GPL(mtk_clk_unregister_plls);
   445	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


                 reply	other threads:[~2022-03-08 23:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203090714.kf7arAXf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=miles.chen@mediatek.com \
    --cc=sboyd@kernel.org \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox