From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792ECC433EF for ; Wed, 9 Mar 2022 00:46:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0BF18D0002; Tue, 8 Mar 2022 19:46:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C939E8D0001; Tue, 8 Mar 2022 19:46:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0D438D0002; Tue, 8 Mar 2022 19:46:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 9DFCE8D0001 for ; Tue, 8 Mar 2022 19:46:23 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B40D22C1B for ; Wed, 9 Mar 2022 00:46:23 +0000 (UTC) X-FDA: 79223006646.13.EE5BB94 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf19.hostedemail.com (Postfix) with ESMTP id 031C61A000A for ; Wed, 9 Mar 2022 00:46:22 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id g20so876577edw.6 for ; Tue, 08 Mar 2022 16:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3TVdSxpJSiaP4MOwCEb1srbEqP/8itZ5hxFbBSfspVU=; b=qfG26zXTlnlLytofDQdjhzVQFVrHlWWJuLEGQbiURbJCyxVT+S/+sCyW4UBw1Tkhr6 8eI5+5BNaRRo9y4XsorMbX4YHDvCFOnXhpgFVbT9DW60svIIJ/2y6XS7v+wkm1WHOqKg WzrT9toQ0hjaXratMNqXPhUbZU9J1602zrv3d78qwPoxlaJfy2RnCJZ4g44NawRFR+ZE W4SP4j8s4u0bhDIpF207Pl2laylCjlqPTWxbyoIBw2chodz7bUNsDHAKIVYqEkyA5Rtk 8Gjh+K1W9qjsBHWp08N13oASyPy8WxzX7E7jr6w3VtPML8CukBoR23hrUXehb/WyQz6D GaAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3TVdSxpJSiaP4MOwCEb1srbEqP/8itZ5hxFbBSfspVU=; b=7RYVQdUA4+3mCtnXebQXwH+6/6HXMEQzKUNbheDTd/L15Co/TTmRR/UJ+HEqAvQWPv Emj+Lkouk5D/CBWSIy0SrrADIKT0xrB5gzwxhtOq0eBu2sGakH0DxLvsv5tbdSnlKVS7 MAP76MmyAYI+bo2dU9yG/cXBnTwVBzrO/nPOXYHTxea43PrQyWZQu2zZB7VboEOVIW8I uXB3IUn9SpfUzEgtUZJ/mCAtfkj5Et0Yy9QSYhSSHGp/9o1/59QWB2l7JKVMsn5d99Xz 4tIHnBp/N/ftTYYTTUXJlZZvldQ+7wtl2CHZs8jigrHYLpbqEGNryUXamjJtJBqpU/M2 hkrQ== X-Gm-Message-State: AOAM533sqzKRk45iZjWQVmcfc1Aokr70eK9FuBY1u6lUHw95fUz7KzOA 3pN6Wxj/layH2mbinbY6o0Y= X-Google-Smtp-Source: ABdhPJwhqoTfTnqz2UHKQ7U01/8pOfHlb3I4XDhRgsrbxI50FYbyWqEeW4niU5JVgCkR8TQpCIvyeQ== X-Received: by 2002:aa7:d403:0:b0:40f:739c:cbae with SMTP id z3-20020aa7d403000000b0040f739ccbaemr18848563edq.267.1646786781541; Tue, 08 Mar 2022 16:46:21 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id gl2-20020a170906e0c200b006a767d52373sm109465ejb.182.2022.03.08.16.46.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Mar 2022 16:46:21 -0800 (PST) Date: Wed, 9 Mar 2022 00:46:20 +0000 From: Wei Yang To: Michal Hocko , hannes@cmpxchg.org Cc: Wei Yang , vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm/memcg: add next_mz back if not reclaimed yet Message-ID: <20220309004620.fgotfh4wsquscbfn@master> Reply-To: Wei Yang References: <20220308012047.26638-1-richard.weiyang@gmail.com> <20220308012047.26638-3-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 031C61A000A X-Stat-Signature: a3iytxgbrdz3tb6bemow1cq4zu3nzp3z Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qfG26zXT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-HE-Tag: 1646786782-621975 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000164, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 08, 2022 at 09:17:58AM +0100, Michal Hocko wrote: >On Tue 08-03-22 01:20:47, Wei Yang wrote: >> next_mz is removed from rb_tree, let's add it back if no reclaim has >> been tried. > >Could you elaborate more why we need/want this? > Per my understanding, we add back the right most node even reclaim makes no progress, so it is reasonable to add back a node if we didn't get a chance to do reclaim on it. It looks like we forget to add it back to the tree. Maybe Johannes know some background why we don't add it back? -- Wei Yang Help you, Help me