linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Qianggui Song <qianggui.song@amlogic.com>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Marc Zyngier <maz@kernel.org>
Subject: [linux-next:master 10152/11353] drivers/irqchip/irq-meson-gpio.c:351:45: warning: variable 'params' set but not used
Date: Tue, 8 Mar 2022 20:34:05 +0800	[thread overview]
Message-ID: <202203082010.Qn0EhDWH-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   cb153b68ff91cbc434f3de70ac549e110543e1bb
commit: d8a61a2ec7e75723083d33800423b151106922e0 [10152/11353] irqchip/meson-gpio: Add support for meson s4 SoCs
config: h8300-buildonly-randconfig-r004-20220307 (https://download.01.org/0day-ci/archive/20220308/202203082010.Qn0EhDWH-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d8a61a2ec7e75723083d33800423b151106922e0
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout d8a61a2ec7e75723083d33800423b151106922e0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/irqchip/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/irqchip/irq-meson-gpio.c: In function 'meson_s4_gpio_irq_set_type':
>> drivers/irqchip/irq-meson-gpio.c:351:45: warning: variable 'params' set but not used [-Wunused-but-set-variable]
     351 |         const struct meson_gpio_irq_params *params;
         |                                             ^~~~~~


vim +/params +351 drivers/irqchip/irq-meson-gpio.c

   330	
   331	/*
   332	 * gpio irq relative registers for s4
   333	 * -PADCTRL_GPIO_IRQ_CTRL0
   334	 * bit[31]:    enable/disable all the irq lines
   335	 * bit[12-23]: single edge trigger
   336	 * bit[0-11]:  polarity trigger
   337	 *
   338	 * -PADCTRL_GPIO_IRQ_CTRL[X]
   339	 * bit[0-16]: 7 bits to choose gpio source for irq line 2*[X] - 2
   340	 * bit[16-22]:7 bits to choose gpio source for irq line 2*[X] - 1
   341	 * where X = 1-6
   342	 *
   343	 * -PADCTRL_GPIO_IRQ_CTRL[7]
   344	 * bit[0-11]: both edge trigger
   345	 */
   346	static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl,
   347					      unsigned int type, u32 *channel_hwirq)
   348	{
   349		u32 val = 0;
   350		unsigned int idx;
 > 351		const struct meson_gpio_irq_params *params;
   352	
   353		params = ctl->params;
   354		idx = meson_gpio_irq_get_channel_idx(ctl, channel_hwirq);
   355	
   356		type &= IRQ_TYPE_SENSE_MASK;
   357	
   358		meson_gpio_irq_update_bits(ctl, REG_EDGE_POL_S4, BIT(idx), 0);
   359	
   360		if (type == IRQ_TYPE_EDGE_BOTH) {
   361			val |= BIT(ctl->params->edge_both_offset + idx);
   362			meson_gpio_irq_update_bits(ctl, REG_EDGE_POL_S4,
   363						   BIT(ctl->params->edge_both_offset + idx), val);
   364			return 0;
   365		}
   366	
   367		if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING))
   368			val |= BIT(ctl->params->pol_low_offset + idx);
   369	
   370		if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
   371			val |= BIT(ctl->params->edge_single_offset + idx);
   372	
   373		meson_gpio_irq_update_bits(ctl, REG_EDGE_POL,
   374					   BIT(idx) | BIT(12 + idx), val);
   375		return 0;
   376	};
   377	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


             reply	other threads:[~2022-03-08 12:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 12:34 kernel test robot [this message]
2022-03-09 11:22 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203082010.Qn0EhDWH-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=maz@kernel.org \
    --cc=qianggui.song@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox