From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C0BC433F5 for ; Fri, 4 Mar 2022 19:19:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 155678D0002; Fri, 4 Mar 2022 14:19:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DDCD8D0001; Fri, 4 Mar 2022 14:19:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC0068D0002; Fri, 4 Mar 2022 14:19:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id D998B8D0001 for ; Fri, 4 Mar 2022 14:19:28 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id AEE7E607AE for ; Fri, 4 Mar 2022 19:19:28 +0000 (UTC) X-FDA: 79207667616.13.10E4E9A Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf24.hostedemail.com (Postfix) with ESMTP id 2A8B2180033 for ; Fri, 4 Mar 2022 19:19:28 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id b11-20020a5b008b000000b00624ea481d55so8169259ybp.19 for ; Fri, 04 Mar 2022 11:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=UDWcKffKui4XwCKVJHIK+JVgQsKzY1Vbou/8cX6kuGw=; b=CskeBnwYi8AGR1jJSShOOv9vPjSw3nXsL0l5QH7mRd/t83w9MJWkOfeGH4iQoL479x pfbd0WWZGZOZSIbK25Gku4N12pDwSd3DXSCGHW0PP8QpWJVpFwfevzo125a4NXBCy2Im 2YcgpvdiAsCDYE7UJJKc6Blc4scDwLzh7DWXz5L/b9aja3S44fW/cdVRODkAai3QV1Or 5GkTgUWg+DFo7OTIRBHrZByAz/iA2yzQpRtM7kPZV37u1LllMhDZpQtI/cuajuNfPqds n4ctvCA5ojacfhEsygQyyY1Uu56hqvg1sMSi2uxGp83PVmcd1ixA6N8iak3UM5Z4dT8C my+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=UDWcKffKui4XwCKVJHIK+JVgQsKzY1Vbou/8cX6kuGw=; b=eWeg76IuK4YoDTD/qjKQZDTNVmbZ5tPsQYkN8LA2Gnyq4HpYjsuAFWaNDvkUQD58sb XOoOvABeKEK3QGpfAJjTtCvIWT4fSxmLWpDtVBIvY/z79TRd7rgPOhhM7p/ZM6HZx9MZ p635rRLLTipxVApwOOcbP4qA6g+IEhAFTgsvR1/i4ksg30JbFdWb3yNx5V3hN1lYfuA/ wD/MdUIKTyfOD357IaU7rv4NetphbNUBOrbYvt2WVhnh70GnjYqFIxpfz6HW1eO1F0vZ cXrOgraJbuT7beRo/mm0oGxYysIy6fdZUhifC9Gck098mvelQLR8wOuS1l1tcOCC4Wni 9bdg== X-Gm-Message-State: AOAM532ykHOOqJMj0qnmZkQEKDqhqxL/KQ9V0Pdf50NEPYgOpnWh73/y weldmQmhqXCeFtb24F7k57u+y0sDt9HQzw== X-Google-Smtp-Source: ABdhPJzojehDkLC7mTTaV1b/BxVv+/dWays+AM4ORyKClLmTCxSgpe0Mqjt2vxpfifi3i2RbT/mKxzIIgJQc4Q== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a5b:f8d:0:b0:628:620c:a45f with SMTP id q13-20020a5b0f8d000000b00628620ca45fmr21458679ybh.17.1646421567384; Fri, 04 Mar 2022 11:19:27 -0800 (PST) Date: Fri, 4 Mar 2022 19:19:24 +0000 In-Reply-To: <20220304170215.1868106-1-eric.dumazet@gmail.com> Message-Id: <20220304191924.75zuylhmgvlb6zt4@google.com> Mime-Version: 1.0 References: <20220304170215.1868106-1-eric.dumazet@gmail.com> Subject: Re: [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held From: Shakeel Butt To: Eric Dumazet Cc: Andrew Morton , linux-kernel , linux-mm , Eric Dumazet , Mel Gorman , Vlastimil Babka , Michal Hocko , Wei Xu , Greg Thelen , Hugh Dickins , David Rientjes Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2A8B2180033 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CskeBnwY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3P2YiYggKCKweTMWQQXNSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3P2YiYggKCKweTMWQQXNSaaSXQ.OaYXUZgj-YYWhMOW.adS@flex--shakeelb.bounces.google.com X-Stat-Signature: zde3jhh4oc5dyt41d54787riwhqkn7az X-HE-Tag: 1646421568-829627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 04, 2022 at 09:02:15AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > For high order pages not using pcp, rmqueue() is currently calling > the costly check_new_pages() while zone spinlock is held, > and hard irqs masked. > This is not needed, we can release the spinlock sooner to reduce > zone spinlock contention. > Note that after this patch, we call __mod_zone_freepage_state() > before deciding to leak the page because it is in bad state. > v2: We need to keep interrupts disabled to call > __mod_zone_freepage_state() > Signed-off-by: Eric Dumazet > Cc: Mel Gorman > Cc: Vlastimil Babka > Cc: Michal Hocko > Cc: Shakeel Butt > Cc: Wei Xu > Cc: Greg Thelen > Cc: Hugh Dickins > Cc: David Rientjes Reviewed-by: Shakeel Butt