From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732B7C433EF for ; Thu, 3 Mar 2022 08:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E1958D0002; Thu, 3 Mar 2022 03:42:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06ADB8D0001; Thu, 3 Mar 2022 03:42:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E754D8D0002; Thu, 3 Mar 2022 03:42:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id D5EEC8D0001 for ; Thu, 3 Mar 2022 03:42:41 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 936B0A0FA1 for ; Thu, 3 Mar 2022 08:42:41 +0000 (UTC) X-FDA: 79202434122.23.B60204A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 1A128100008 for ; Thu, 3 Mar 2022 08:42:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78F9C61B11; Thu, 3 Mar 2022 08:42:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7237BC004E1; Thu, 3 Mar 2022 08:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646296957; bh=wxx3qu0sZ0wQv3hV3t/+/URflGLqV8/abpb8AHjS6C0=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=ffszb4I60l5M5WMVrHLPIVQQ2S1VhGgAcyC4rX5vqFN+04Frzv1IHDLCuqPu81n0L WDsu8UNbVQJNZDiaXpkAsdujuKhx6Ju9iIlV5PWMnfxDK1CUEyBbfMdRtSnjfqrWyS afyvS2wVV42YoL/87PfsJb4Me6pjRiTK89fmodWi6iu8SYkzUsm7p0nT4ZgxrcfXBl AeZ8q2NyPwxwzvs/49E+0/LXm3dplkhTn7giMvVGzYuQoKHVKrwijfz0gLS/4mn/3Z 7jp41i6tzs3SMSymTS9qlxXUYHQH3wW/qLuFplILfq5CyGD5HRFEiu8IlAKHNgNaAW dOBUatl8q/ukw== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: remove repeat container_of() in damon_sysfs_kdamond_release() Date: Thu, 3 Mar 2022 08:42:35 +0000 Message-Id: <20220303084235.356-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220303075314.22502-1-xhao@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1A128100008 X-Stat-Signature: mytidb9rtxco63xjeuc9ta6cixejrafk Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ffszb4I6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1646296960-782606 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Thu, 3 Mar 2022 15:53:14 +0800 Xin Hao wrote: > In damon_sysfs_kdamond_release(), we have use container_of() to get > "kdamond" pointer, so there no need to get it once again. Good catch! Thank you always :) > > Signed-off-by: Xin Hao Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index a4ad6b473b0a..687e7c7e8dea 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2432,7 +2432,7 @@ static void damon_sysfs_kdamond_release(struct kobject *kobj) > > if (kdamond->damon_ctx) > damon_destroy_ctx(kdamond->damon_ctx); > - kfree(container_of(kobj, struct damon_sysfs_kdamond, kobj)); > + kfree(kdamond); > } > > static struct kobj_attribute damon_sysfs_kdamond_state_attr = > -- > 2.27.0