From: "Michal Koutný" <mkoutny@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-mm@kvack.org, Igor Zhbanov <i.zhbanov@omprussia.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/memcontrol: return 1 from cgroup.memory __setup() handler
Date: Wed, 2 Mar 2022 19:53:00 +0100 [thread overview]
Message-ID: <20220302185300.GA19699@blackbody.suse.cz> (raw)
In-Reply-To: <20220222005811.10672-1-rdunlap@infradead.org>
On Mon, Feb 21, 2022 at 04:58:11PM -0800, Randy Dunlap <rdunlap@infradead.org> wrote:
> __setup() handlers should return 1 if the command line option is handled
> and 0 if not (or maybe never return 0; it just pollutes init's environment).
Interesting.
> Instead of relying on this '.' quirk, just return 1 to indicate that
> the boot option has been handled.
But your patch would return 1 even when no accepted value was passed,
i.e. is the command line option considered handled in that case?
Did you want to return 1 only when the cgroup.memory= value is
recognized?
Thanks,
Michal
next prev parent reply other threads:[~2022-03-02 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 0:58 Randy Dunlap
2022-03-02 18:53 ` Michal Koutný [this message]
2022-03-03 0:53 ` Randy Dunlap
2022-03-03 10:14 ` Michal Koutný
2022-03-03 21:53 ` Randy Dunlap
2022-03-03 22:32 ` Michal Koutný
2022-03-03 22:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302185300.GA19699@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=i.zhbanov@omprussia.ru \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rdunlap@infradead.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox