From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA489C433F5 for ; Wed, 2 Mar 2022 20:53:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B558D0002; Wed, 2 Mar 2022 15:53:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A4BF8D0001; Wed, 2 Mar 2022 15:53:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26C5B8D0002; Wed, 2 Mar 2022 15:53:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 114FC8D0001 for ; Wed, 2 Mar 2022 15:53:37 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C93118249980 for ; Wed, 2 Mar 2022 20:53:36 +0000 (UTC) X-FDA: 79200647232.25.9557019 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 1D7CB1C000C for ; Wed, 2 Mar 2022 20:53:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 03E26CE23B3; Wed, 2 Mar 2022 20:53:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22413C340E9; Wed, 2 Mar 2022 20:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1646254410; bh=TgloV4B2vCHdyFP/LtMGAUPUvrUDGKFnl1FOodTZlcI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ju0i4BULb8yoAdghQyVOOuGhBEhxPN1NBrXlxuAeZbje+6657mDkuLw9rQvumpEx0 x8BvHCVbA8QBeOZNJ+lGhMfCgDJQlANOCRKSLmElPKAgu50rpcT00004hN4HLdDT39 VyRrPTW+nM4/gLe253KnWBeB4BUEyH95lbGZn6ZA= Date: Wed, 2 Mar 2022 12:53:29 -0800 From: Andrew Morton To: Colin Ian King Cc: SeongJae Park , Stephen Rothwell , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: Fix an array out-of-bounds read error due Message-Id: <20220302125329.65bc251ab9c2df865146a5ae@linux-foundation.org> In-Reply-To: <20220302180252.1099406-1-colin.i.king@gmail.com> References: <20220302180252.1099406-1-colin.i.king@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1D7CB1C000C X-Stat-Signature: w8j7518knaaydqb1y6h5311qpkptnt9p Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ju0i4BUL; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1646254415-129029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Mar 2022 18:02:52 +0000 Colin Ian King wrote: > There is an off-by-one error in the upper limit to a for-loop that > causes an out-of-bounds read error on the array > damon_sysfs_wmark_metric_strs. Fix the comparison by replacing > the <= operator with <. > Thanks, we already have https://lkml.kernel.org/r/20220301185619.2904-1-sj@kernel.org