From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A86C433EF for ; Tue, 1 Mar 2022 18:24:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3DD8D0002; Tue, 1 Mar 2022 13:24:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D60DB8D0001; Tue, 1 Mar 2022 13:24:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C50058D0002; Tue, 1 Mar 2022 13:24:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id B551F8D0001 for ; Tue, 1 Mar 2022 13:24:55 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 70472181C4420 for ; Tue, 1 Mar 2022 18:24:55 +0000 (UTC) X-FDA: 79196643750.22.1D82CD1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id BCB6140009 for ; Tue, 1 Mar 2022 18:24:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 391D1B81BF5; Tue, 1 Mar 2022 18:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C5EC340EE; Tue, 1 Mar 2022 18:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1646159089; bh=n/9fph0OsL5mWwjCtTZsQ6kPOtBrGnou15HhkeitYVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ckVbb9w9WVZ2MiNi83aQBsFy2DyavnCa3DU4epjPmJZLSesO9NcNtK0X2w3tzoYTJ tCR85yHgMG3gM9aa+i2rVjje5otvlJ7vcxullMf3u/yR9ZYY2M2bR2iQ642V77Uv/z i8/gEtbOvxOR7dJl9RgOQK/V0KNdJeHobxCkdenw= Date: Tue, 1 Mar 2022 10:24:48 -0800 From: Andrew Morton To: kernel test robot Cc: Maninder Singh , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Johannes Weiner , Vaneet Narang , Linux Memory Management List , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , John Ogness Subject: Re: [hnaz-mm:master 272/379] lib/vsprintf.c:991:13: warning: variable 'modbuildid' set but not used Message-Id: <20220301102448.ff9bf910213d705842a2dd45@linux-foundation.org> In-Reply-To: <202203012040.uFWGm3My-lkp@intel.com> References: <202203012040.uFWGm3My-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BCB6140009 X-Stat-Signature: j6ioqdf77uy736c8t4es3j3ouqn1zzmo Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ckVbb9w9; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1646159092-925567 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 1 Mar 2022 20:11:04 +0800 kernel test robot wrote: > tree: https://github.com/hnaz/linux-mm master > head: a46912c14343fd3269cc133494988af90b377d9f > commit: b314f622e664eb263ea03ef7f4580e37146f123f [272/379] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled > config: arm-eseries_pxa_defconfig (https://download.01.org/0day-ci/archive/20220301/202203012040.uFWGm3My-lkp@intel.com/config) > compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/hnaz/linux-mm/commit/b314f622e664eb263ea03ef7f4580e37146f123f > git remote add hnaz-mm https://github.com/hnaz/linux-mm > git fetch --no-tags hnaz-mm master > git checkout b314f622e664eb263ea03ef7f4580e37146f123f > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > lib/vsprintf.c: In function 'sprint_module_info': > >> lib/vsprintf.c:991:13: warning: variable 'modbuildid' set but not used [-Wunused-but-set-variable] > 991 | int modbuildid = 0; > | ^~~~~~~~~~ Do we care about this? [-Wunused-but-set-variable isn't normally set. Under what circumstances does it get set in your setup? I did this: --- a/lib/vsprintf.c~kallsyms-enhance-%ps-s-b-printing-when-kallsysms-is-disabled-fix +++ a/lib/vsprintf.c @@ -988,7 +988,7 @@ static int sprint_module_info(char *buf, unsigned long base; int ret = 0; const char *modname; - int modbuildid = 0; + int modbuildid __maybe_unused = 0; int len; #if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) const unsigned char *buildid = NULL; _ > lib/vsprintf.c: In function 'va_format': > lib/vsprintf.c:1759:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] > 1759 | buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va); > | ^~~ I wonder what this means.