From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063CBC433FE for ; Tue, 1 Mar 2022 07:59:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BC318D0008; Tue, 1 Mar 2022 02:59:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 944B48D0001; Tue, 1 Mar 2022 02:59:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E7828D0008; Tue, 1 Mar 2022 02:59:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 6FA018D0001 for ; Tue, 1 Mar 2022 02:59:21 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4535E23D5B for ; Tue, 1 Mar 2022 07:59:21 +0000 (UTC) X-FDA: 79195067322.06.F1019D5 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf24.hostedemail.com (Postfix) with ESMTP id BB7AD180006 for ; Tue, 1 Mar 2022 07:59:20 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id bc27so4880144pgb.4 for ; Mon, 28 Feb 2022 23:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3aKejJw1nR/er0PaT33ysU9JAPbiP/BO+fmavRczddA=; b=MkwrLGU+BDmEg5akmiJV5iuAGXoVQex9eAJamjRI5yPEwQz5ZBphS8rWxnJoh6r2qk GITpdBUCOCJKhpDPKvimmGQSnQYAGyWqE3P/+tlqY8/Lu4X9F1UCmP0Z1BSnNx23hj2H UtRYDHpyz0wyS3HBEihDOvYCmXO68ii5OY2AqwLcziJx5hhINrQq37iUPti6770WqH72 1+XtxGGGSMNbhBmEy4L8XvJ2nezmqom4+TByy//BriSjcIkpn9hXnEZncRbOhKFatyZi G1bY7lVc2k/YjXTfPPTknwvPMtj6AurwobswVDg4xT3ibtE/DX12Ms7BPAu681KRpKyf EYkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3aKejJw1nR/er0PaT33ysU9JAPbiP/BO+fmavRczddA=; b=puwM8qixXgISY27JleThOyulgkHVC3zSIanWNuLV44WK6ew8yAIz4AlepOYCZS/lN3 gqXaSxJ2oHXh/+R4u4PG/Qo1mLNbiAH53lLaNjCk7Njv/KUKbv33LzUdYgfeY7TUIDtq U6WknY7fHJSMv4yPtqAwMyyHDFA++fK4C798lK6snmL4I8xwLGnwaH6xPKi2ictVaKL1 LK3HkQSHjadG1VLXiye7sQNqEq37OAO3vULtMl+MKi3XVwLET92mPvmH/5f+uIJ0cAvE TvubRXJRTPaeWoc4BXLcYoLDfLYxGxGHAfs6lnChfgEpkqEEKGeo6/JnMex2n88yx7dL vbYQ== X-Gm-Message-State: AOAM530EWefx7vCqd7jak/44B/JUgJL0/gxVzeBokYKDddxu/V90mGel PUtZ9MXkt5fOWP1Wll+rHOs= X-Google-Smtp-Source: ABdhPJzsmChq0SMT6w+a5llB+evOvw/vtlrBOBuie32yTHIMn9w2PHQgwGyq50KU4/df9sG257/q1g== X-Received: by 2002:a05:6a00:124f:b0:4c0:6242:c14e with SMTP id u15-20020a056a00124f00b004c06242c14emr25860679pfi.83.1646121559737; Mon, 28 Feb 2022 23:59:19 -0800 (PST) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id o12-20020a17090aac0c00b001b9e5286c90sm1662745pjq.0.2022.02.28.23.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 23:59:19 -0800 (PST) From: Xiaomeng Tong To: torvalds@linux-foundation.org Cc: arnd@arndb.de, jakobkoschel@gmail.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, keescook@chromium.org, jannh@google.com, linux-kbuild@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, Xiaomeng Tong Subject: [PATCH 5/6] net/core: remove iterator use outside the loop Date: Tue, 1 Mar 2022 15:58:38 +0800 Message-Id: <20220301075839.4156-6-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301075839.4156-1-xiam0nd.tong@gmail.com> References: <20220301075839.4156-1-xiam0nd.tong@gmail.com> X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: ynt7tx94rkg39uudiwri4jwqfq89n8xh Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MkwrLGU+; spf=pass (imf24.hostedemail.com: domain of xiam0nd.tong@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=xiam0nd.tong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: BB7AD180006 X-HE-Tag: 1646121560-968433 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Demonstrations for: - list_for_each_entry_safe_reverse_inside Signed-off-by: Xiaomeng Tong --- net/core/gro.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/gro.c b/net/core/gro.c index a11b286d1..4d4f1f2fb 100644 --- a/net/core/gro.c +++ b/net/core/gro.c @@ -286,9 +286,8 @@ static void __napi_gro_flush_chain(struct napi_struct *napi, u32 index, bool flush_old) { struct list_head *head = &napi->gro_hash[index].list; - struct sk_buff *skb, *p; - list_for_each_entry_safe_reverse(skb, p, head, list) { + list_for_each_entry_safe_reverse_inside(skb, p, struct sk_buff, head, list) { if (flush_old && NAPI_GRO_CB(skb)->age == jiffies) return; skb_list_del_init(skb); -- 2.17.1