From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 4/4] mm/memory-failure.c: fix potential VM_BUG_ON_PAGE in split_huge_page_to_list
Date: Mon, 28 Feb 2022 22:02:45 +0800 [thread overview]
Message-ID: <20220228140245.24552-5-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220228140245.24552-1-linmiaohe@huawei.com>
The huge zero page could reach here and if we ever try to split it, the
VM_BUG_ON_PAGE will be triggered in split_huge_page_to_list(). Also the
non-lru compound movable pages could be taken for transhuge pages. Skip
these pages by checking PageLRU because huge zero page isn't lru page as
non-lru compound movable pages.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory-failure.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 23bfd809dc8c..ac6492e36978 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1792,6 +1792,20 @@ int memory_failure(unsigned long pfn, int flags)
}
if (PageTransHuge(hpage)) {
+ /*
+ * The non-lru compound movable pages could be taken for
+ * transhuge pages. Also huge zero page could reach here
+ * and if we ever try to split it, the VM_BUG_ON_PAGE will
+ * be triggered in split_huge_page_to_list(). Skip these
+ * pages by checking PageLRU because huge zero page isn't
+ * lru page as non-lru compound movable pages.
+ */
+ if (!PageLRU(hpage)) {
+ put_page(p);
+ action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED);
+ res = -EBUSY;
+ goto unlock_mutex;
+ }
/*
* The flag must be set after the refcount is bumped
* otherwise it may race with THP split.
--
2.23.0
next prev parent reply other threads:[~2022-02-28 14:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:02 [PATCH 0/4] A few fixup patches for memory failure Miaohe Lin
2022-02-28 14:02 ` [PATCH 1/4] mm/memory-failure.c: fix race with changing page compound again Miaohe Lin
2022-03-04 8:26 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-04 19:32 ` Mike Kravetz
2022-03-07 3:44 ` Miaohe Lin
2022-03-07 7:01 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-07 19:07 ` Mike Kravetz
2022-03-08 6:56 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-08 11:28 ` Miaohe Lin
2022-02-28 14:02 ` [PATCH 2/4] mm/memory-failure.c: fix wrong user reference report Miaohe Lin
2022-03-04 8:27 ` HORIGUCHI NAOYA(堀口 直也)
2022-03-07 11:26 ` Miaohe Lin
2022-03-07 20:14 ` Yang Shi
2022-03-08 13:11 ` Miaohe Lin
2022-03-08 18:51 ` Yang Shi
2022-03-09 8:30 ` Miaohe Lin
2022-02-28 14:02 ` [PATCH 3/4] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages Miaohe Lin
2022-02-28 14:02 ` Miaohe Lin [this message]
2022-03-04 8:28 ` [PATCH 4/4] mm/memory-failure.c: fix potential VM_BUG_ON_PAGE in split_huge_page_to_list HORIGUCHI NAOYA(堀口 直也)
2022-03-07 7:07 ` Miaohe Lin
2022-03-07 19:53 ` Yang Shi
2022-03-08 12:36 ` Miaohe Lin
2022-03-08 18:47 ` Yang Shi
2022-03-09 8:45 ` Miaohe Lin
2022-03-10 11:46 ` Miaohe Lin
2022-03-10 19:32 ` Yang Shi
2022-03-11 1:54 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228140245.24552-5-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox