From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15FD2C433EF for ; Mon, 28 Feb 2022 04:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B7B48D0002; Sun, 27 Feb 2022 23:47:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 665DC8D0001; Sun, 27 Feb 2022 23:47:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57C298D0002; Sun, 27 Feb 2022 23:47:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 44E108D0001 for ; Sun, 27 Feb 2022 23:47:32 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EF1B299E86 for ; Mon, 28 Feb 2022 04:47:31 +0000 (UTC) X-FDA: 79190955102.21.325F644 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 63776160002 for ; Mon, 28 Feb 2022 04:47:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E6CC60748; Mon, 28 Feb 2022 04:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3FC0C340E7; Mon, 28 Feb 2022 04:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1646023649; bh=G8sG7lhMtemU8UaIfAlQyFfdM52xrPiAjoIoRCmr5pk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oGPNq6p6XPM77SHgO9aQqRI1rnuXHCc+59DXZQ1WNrGmN3OQd6S99TorBGhKumdok /al88n7DG2J8BkHYEPTcnC3PkoeWXPmOgtseuFvQx3PRiJwblKmCI9fhBlhdsjcaOW hLr6Rg6R30jUXs/Md/sM9bDGeMUMnt9uzXly3vn0= Date: Sun, 27 Feb 2022 20:47:28 -0800 From: Andrew Morton To: "NeilBrown" Cc: "Jan Kara" , "Wu Fengguang" , "Jaegeuk Kim" , "Chao Yu" , "Jeff Layton" , "Ilya Dryomov" , "Miklos Szeredi" , "Trond Myklebust" , "Anna Schumaker" , "Ryusuke Konishi" , "Darrick J. Wong" , "Philipp Reisner" , "Lars Ellenberg" , "Paolo Valente" , "Jens Axboe" , linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, ceph-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 02/11] MM: document and polish read-ahead code. Message-Id: <20220227204728.b2eb5dd94ecc3e86912bacad@linux-foundation.org> In-Reply-To: <164602251992.20161.9146570952337454229@noble.neil.brown.name> References: <164447124918.23354.17858831070003318849.stgit@noble.brown> <164447147257.23354.2801426518649016278.stgit@noble.brown> <20220210122440.vqth5mwsqtv6vjpq@quack3.lan> <164453611721.27779.1299851963795418722@noble.neil.brown.name> <20220224182622.n7abfey3asszyq3x@quack3.lan> <164602251992.20161.9146570952337454229@noble.neil.brown.name> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 63776160002 X-Stat-Signature: rxcyxwqy5967hwyio3e7o5cr1yzbh46t Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oGPNq6p6; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1646023651-742823 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 28 Feb 2022 15:28:39 +1100 "NeilBrown" wrote: > When writing documentation the intent of the author is of some interest, > but the behaviour of the code is paramount. uh, er, ah, no. The code describes the behaviour of the code. The comments are there to describe things other than the code's behaviour. Things such as the author's intent. Any deviation between the author's intent and the code's behaviour is called a "bug", so it's pretty important to understand authorial intent, no?