From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331DBC433F5 for ; Sat, 26 Feb 2022 01:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2DDF8D0002; Fri, 25 Feb 2022 20:03:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADCEC8D0001; Fri, 25 Feb 2022 20:03:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CB838D0002; Fri, 25 Feb 2022 20:03:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 8CFD48D0001 for ; Fri, 25 Feb 2022 20:03:10 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 5E70380226 for ; Sat, 26 Feb 2022 01:03:10 +0000 (UTC) X-FDA: 79183132140.09.63A681A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id B2F1D80002 for ; Sat, 26 Feb 2022 01:03:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EA838B81F83; Sat, 26 Feb 2022 01:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A965C340E7; Sat, 26 Feb 2022 01:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1645837386; bh=43pC9PdIzse0ZGz/ZNK8Q2fCOABbfYyUP49hGYhr+JA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m8uVK/IXP+hcQZtmdTES0fUSK/NmDeUqxCfezFUmK1NZO/9GClJWz8A5Sq2KgwOnZ bNwqN+Tq9mT436P9e5HntTMXhPo488hm0F7i2/TdRR1lzwjBb55qxhLiwF0rCGouku oiilh/6zQKhlEE2qCeCLWAbFaNbxUYlYWRID6W0g= Date: Fri, 25 Feb 2022 17:03:05 -0800 From: Andrew Morton To: Guillaume Tucker Cc: Shuah Khan , Borislav Petkov , Dave Hansen , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests, x86: fix how check_cc.sh is being invoked Message-Id: <20220225170305.de0aa0dc898ca583d8a83e5c@linux-foundation.org> In-Reply-To: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com> References: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B2F1D80002 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="m8uVK/IX"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: zqa4hyxbw846khjtpjsu9yixmciznu3f X-HE-Tag: 1645837389-808184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 25 Feb 2022 13:15:43 +0000 Guillaume Tucker wrote: > Add quotes around $(CC) when calling check_cc.sh from a Makefile to > pass the value as a single argument to the script even if it has > several words such as "ccache gcc". Conversely, remove quotes in > check_cc.sh when calling $CC to make it a command with potentially > several arguments again. This changelog describes the fix, but it fails to describe the problem which the patch is fixing! Presumably, we're hitting some form of runtime failure under undescribed circumstances when running selftests. But that's just me reverse-engineering the patch description. And me reverse-engineering stuff is a gloriously unreliable thing. Please spell out the problem.