From: Andrew Morton <akpm@linux-foundation.org>
To: Guillaume Tucker <guillaume.tucker@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>, Borislav Petkov <bp@suse.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
kernel@collabora.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests, x86: fix how check_cc.sh is being invoked
Date: Fri, 25 Feb 2022 17:03:05 -0800 [thread overview]
Message-ID: <20220225170305.de0aa0dc898ca583d8a83e5c@linux-foundation.org> (raw)
In-Reply-To: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com>
On Fri, 25 Feb 2022 13:15:43 +0000 Guillaume Tucker <guillaume.tucker@collabora.com> wrote:
> Add quotes around $(CC) when calling check_cc.sh from a Makefile to
> pass the value as a single argument to the script even if it has
> several words such as "ccache gcc". Conversely, remove quotes in
> check_cc.sh when calling $CC to make it a command with potentially
> several arguments again.
This changelog describes the fix, but it fails to describe the problem
which the patch is fixing!
Presumably, we're hitting some form of runtime failure under
undescribed circumstances when running selftests. But that's just me
reverse-engineering the patch description. And me reverse-engineering
stuff is a gloriously unreliable thing. Please spell out the problem.
next prev parent reply other threads:[~2022-02-26 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 13:15 Guillaume Tucker
2022-02-25 18:49 ` Guillaume Tucker
2022-02-25 21:38 ` David Laight
2022-02-26 1:03 ` Andrew Morton [this message]
2022-03-11 10:15 ` Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225170305.de0aa0dc898ca583d8a83e5c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=guillaume.tucker@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox