* [PATCH] lib: maple_tree: fix boolreturn.cocci warning
@ 2022-02-25 6:31 Wan Jiabing
2022-02-25 14:50 ` Liam Howlett
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2022-02-25 6:31 UTC (permalink / raw)
To: Liam R. Howlett, linux-mm, linux-kernel; +Cc: jiabing.wan, Wan Jiabing
Fix following coccicheck warning:
./lib/maple_tree.c:4177:9-10: WARNING: return of 0/1 in function
mas_wr_append with return type bool.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
lib/maple_tree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 5f7295ba0309..933483726b85 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -4174,7 +4174,7 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
mas->offset = new_end;
wr_mas->pivots[end] = mas->index - 1;
- return 1;
+ return true;
} else if ((mas->index == wr_mas->r_min) && (mas->last < wr_mas->r_max)) {
if (new_end < node_pivots)
wr_mas->pivots[new_end] = wr_mas->pivots[end];
@@ -4185,9 +4185,9 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
wr_mas->pivots[end] = mas->last;
rcu_assign_pointer(wr_mas->slots[end], wr_mas->entry);
- return 1;
+ return true;
}
- return 0;
+ return false;
}
static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] lib: maple_tree: fix boolreturn.cocci warning
2022-02-25 6:31 [PATCH] lib: maple_tree: fix boolreturn.cocci warning Wan Jiabing
@ 2022-02-25 14:50 ` Liam Howlett
0 siblings, 0 replies; 2+ messages in thread
From: Liam Howlett @ 2022-02-25 14:50 UTC (permalink / raw)
To: Wan Jiabing; +Cc: linux-mm, linux-kernel, jiabing.wan
Thanks for the report, I will make this change in linux-next
Liam
* Wan Jiabing <wanjiabing@vivo.com> [220225 01:31]:
> Fix following coccicheck warning:
> ./lib/maple_tree.c:4177:9-10: WARNING: return of 0/1 in function
> mas_wr_append with return type bool.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> lib/maple_tree.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 5f7295ba0309..933483726b85 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4174,7 +4174,7 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
> mas->offset = new_end;
> wr_mas->pivots[end] = mas->index - 1;
>
> - return 1;
> + return true;
> } else if ((mas->index == wr_mas->r_min) && (mas->last < wr_mas->r_max)) {
> if (new_end < node_pivots)
> wr_mas->pivots[new_end] = wr_mas->pivots[end];
> @@ -4185,9 +4185,9 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
>
> wr_mas->pivots[end] = mas->last;
> rcu_assign_pointer(wr_mas->slots[end], wr_mas->entry);
> - return 1;
> + return true;
> }
> - return 0;
> + return false;
> }
>
> static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-25 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 6:31 [PATCH] lib: maple_tree: fix boolreturn.cocci warning Wan Jiabing
2022-02-25 14:50 ` Liam Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox