From: Liam Howlett <liam.howlett@oracle.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiabing.wan@qq.com" <jiabing.wan@qq.com>
Subject: Re: [PATCH] lib: maple_tree: fix boolreturn.cocci warning
Date: Fri, 25 Feb 2022 14:50:25 +0000 [thread overview]
Message-ID: <20220225145017.32ev2rjtf2b673rg@revolver> (raw)
In-Reply-To: <20220225063101.891725-1-wanjiabing@vivo.com>
Thanks for the report, I will make this change in linux-next
Liam
* Wan Jiabing <wanjiabing@vivo.com> [220225 01:31]:
> Fix following coccicheck warning:
> ./lib/maple_tree.c:4177:9-10: WARNING: return of 0/1 in function
> mas_wr_append with return type bool.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> lib/maple_tree.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 5f7295ba0309..933483726b85 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4174,7 +4174,7 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
> mas->offset = new_end;
> wr_mas->pivots[end] = mas->index - 1;
>
> - return 1;
> + return true;
> } else if ((mas->index == wr_mas->r_min) && (mas->last < wr_mas->r_max)) {
> if (new_end < node_pivots)
> wr_mas->pivots[new_end] = wr_mas->pivots[end];
> @@ -4185,9 +4185,9 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
>
> wr_mas->pivots[end] = mas->last;
> rcu_assign_pointer(wr_mas->slots[end], wr_mas->entry);
> - return 1;
> + return true;
> }
> - return 0;
> + return false;
> }
>
> static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
> --
> 2.35.1
>
prev parent reply other threads:[~2022-02-25 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 6:31 Wan Jiabing
2022-02-25 14:50 ` Liam Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225145017.32ev2rjtf2b673rg@revolver \
--to=liam.howlett@oracle.com \
--cc=jiabing.wan@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox