linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 6791/7915] arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'; have 'int(void)'
Date: Fri, 25 Feb 2022 01:44:02 +0000	[thread overview]
Message-ID: <20220225014400.lvz4pxu5l2miznb4@revolver> (raw)
In-Reply-To: <YhfeOriKV/iAV8bD@casper.infradead.org>

* Matthew Wilcox <willy@infradead.org> [220224 14:41]:
> On Thu, Feb 24, 2022 at 06:42:52PM +0000, Liam Howlett wrote:
> > >    include/linux/maple_tree.h:589:20: note: previous definition of 'mt_init' with type 'void(struct maple_tree *)'
> > >      589 | static inline void mt_init(struct maple_tree *mt)
> > >          |                    ^~~~~~~
> > > 
> > > 
> > > vim +233 arch/mips/kernel/mips-mt.c
> > 
> > 
> > Naming is hard, all the good ones are taken.  I'll rename the maple tree
> > init.
> 
> Actually, I think it's probably better to rename the existing one.
> mips_mt_init() would be fine.
> 

Sounds good.  mips_mt_init() fits with the other function names in
mips-mt.c

Thanks,
Liam


      reply	other threads:[~2022-02-25  1:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 10:13 kernel test robot
2022-02-24 18:42 ` Liam Howlett
2022-02-24 19:36   ` Matthew Wilcox
2022-02-25  1:44     ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225014400.lvz4pxu5l2miznb4@revolver \
    --to=liam.howlett@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox