From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34112C433EF for ; Thu, 24 Feb 2022 10:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEA038D0002; Thu, 24 Feb 2022 05:45:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A99E98D0001; Thu, 24 Feb 2022 05:45:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987A98D0002; Thu, 24 Feb 2022 05:45:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 860348D0001 for ; Thu, 24 Feb 2022 05:45:47 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44B3723641 for ; Thu, 24 Feb 2022 10:45:47 +0000 (UTC) X-FDA: 79177342734.12.9E3E59A Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf10.hostedemail.com (Postfix) with ESMTP id BD2B5C0005 for ; Thu, 24 Feb 2022 10:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645699463; x=1677235463; h=date:from:to:cc:subject:message-id:mime-version; bh=xESBG4/jyA4FAMoPXGie0n4PdZood0TNu1idzpebtEc=; b=AMmk+s2hwVsrr/rUNX+CItFHWf4uuh0iJlRyfJxQwAvRW937T2YNcoMo m/+lm+IoLKjKgD6vTjo3YhD92Xy3/ctBVNLi4NErC9O0SRDljgv1hOI4j e5/4Ugt0j3GnGnj+LDcIjbuCR9TN4HJ+d7rnH69ddFcwYPP80+pQmX7+w N9mKF1kxqOcQPrKo3lXM8lt6shP2sE2TfofgVmOpF+YjQAIsz5zMuinus Ag8sKg9UdTRBz6FwkluqJZzrIpgrgNbuW++ii4W0+j4Nd7zGn9/L2JOZK pdaZill8TY+81l8b6fTIkWvcOPskVr9OdPi+rRm8KSCV4ougk8+jPxPkE w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="252124544" X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="252124544" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 02:44:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="574166635" Received: from lkp-server01.sh.intel.com (HELO 788b1cd46f0d) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 24 Feb 2022 02:44:20 -0800 Received: from kbuild by 788b1cd46f0d with local (Exim 4.92) (envelope-from ) id 1nNBbf-00030q-JY; Thu, 24 Feb 2022 10:44:19 +0000 Date: Thu, 24 Feb 2022 18:44:12 +0800 From: kernel test robot To: Xiaoming Ni Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Andrew Morton , Linux Memory Management List Subject: kernel/stackleak.c:33:50: sparse: sparse: incorrect type in argument 3 (different address spaces) Message-ID: <202202241831.OT84m49q-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AMmk+s2h; spf=none (imf10.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BD2B5C0005 X-Stat-Signature: dwft1u3nko3h38z187tqw6z8767p9fdj X-HE-Tag: 1645699463-862607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 23d04328444a8fa0ca060c5e532220dac8e8bc26 commit: 0df8bdd5e3b3e557ce2c2575fce0c64c5dd1045a stackleak: move stack_erasing sysctl to stackleak.c date: 5 weeks ago config: arm64-randconfig-s031-20220223 (https://download.01.org/0day-ci/archive/20220224/202202241831.OT84m49q-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0df8bdd5e3b3e557ce2c2575fce0c64c5dd1045a git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 0df8bdd5e3b3e557ce2c2575fce0c64c5dd1045a # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> kernel/stackleak.c:33:50: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void * @@ got void [noderef] __user *buffer @@ kernel/stackleak.c:33:50: sparse: expected void * kernel/stackleak.c:33:50: sparse: got void [noderef] __user *buffer >> kernel/stackleak.c:53:35: sparse: sparse: incorrect type in initializer (incompatible argument 3 (different address spaces)) @@ expected int ( [usertype] *proc_handler )( ... ) @@ got int ( * )( ... ) @@ kernel/stackleak.c:53:35: sparse: expected int ( [usertype] *proc_handler )( ... ) kernel/stackleak.c:53:35: sparse: got int ( * )( ... ) vim +33 kernel/stackleak.c 964c9dff009189 Alexander Popov 2018-08-17 22 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 23 #ifdef CONFIG_SYSCTL 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 24 static int stack_erasing_sysctl(struct ctl_table *table, int write, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 25 void __user *buffer, size_t *lenp, loff_t *ppos) 964c9dff009189 Alexander Popov 2018-08-17 26 { 964c9dff009189 Alexander Popov 2018-08-17 27 int ret = 0; 964c9dff009189 Alexander Popov 2018-08-17 28 int state = !static_branch_unlikely(&stack_erasing_bypass); 964c9dff009189 Alexander Popov 2018-08-17 29 int prev_state = state; 964c9dff009189 Alexander Popov 2018-08-17 30 964c9dff009189 Alexander Popov 2018-08-17 31 table->data = &state; 964c9dff009189 Alexander Popov 2018-08-17 32 table->maxlen = sizeof(int); 964c9dff009189 Alexander Popov 2018-08-17 @33 ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); 964c9dff009189 Alexander Popov 2018-08-17 34 state = !!state; 964c9dff009189 Alexander Popov 2018-08-17 35 if (ret || !write || state == prev_state) 964c9dff009189 Alexander Popov 2018-08-17 36 return ret; 964c9dff009189 Alexander Popov 2018-08-17 37 964c9dff009189 Alexander Popov 2018-08-17 38 if (state) 964c9dff009189 Alexander Popov 2018-08-17 39 static_branch_disable(&stack_erasing_bypass); 964c9dff009189 Alexander Popov 2018-08-17 40 else 964c9dff009189 Alexander Popov 2018-08-17 41 static_branch_enable(&stack_erasing_bypass); 964c9dff009189 Alexander Popov 2018-08-17 42 964c9dff009189 Alexander Popov 2018-08-17 43 pr_warn("stackleak: kernel stack erasing is %s\n", 964c9dff009189 Alexander Popov 2018-08-17 44 state ? "enabled" : "disabled"); 964c9dff009189 Alexander Popov 2018-08-17 45 return ret; 964c9dff009189 Alexander Popov 2018-08-17 46 } 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 47 static struct ctl_table stackleak_sysctls[] = { 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 48 { 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 49 .procname = "stack_erasing", 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 50 .data = NULL, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 51 .maxlen = sizeof(int), 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 52 .mode = 0600, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 @53 .proc_handler = stack_erasing_sysctl, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 54 .extra1 = SYSCTL_ZERO, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 55 .extra2 = SYSCTL_ONE, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 56 }, 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 57 {} 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 58 }; 0df8bdd5e3b3e5 Xiaoming Ni 2022-01-21 59 :::::: The code at line 33 was first introduced by commit :::::: 964c9dff0091893a9a74a88edf984c6da0b779f7 stackleak: Allow runtime disabling of kernel stack erasing :::::: TO: Alexander Popov :::::: CC: Kees Cook --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org