linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: kernel test robot <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [linux-next:master 6797/7915] mm/mmap.c:754:6: warning: no previous prototype for 'vma_store'
Date: Thu, 24 Feb 2022 18:23:13 +0000	[thread overview]
Message-ID: <20220224182307.oyqkzurlgjq52xnn@revolver> (raw)
In-Reply-To: <202202241600.1WmL7XfG-lkp@intel.com>

* kernel test robot <lkp@intel.com> [220224 03:52]:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: e1345552730700c6b405d20acdfb92da77d0cdbf [6797/7915] kernel/fork: Use maple tree for dup_mmap() during forking
> config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220224/202202241600.1WmL7XfG-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e1345552730700c6b405d20acdfb92da77d0cdbf
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout e1345552730700c6b405d20acdfb92da77d0cdbf
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/mmap.c:754:6: warning: no previous prototype for 'vma_store' [-Wmissing-prototypes]
>      754 | void vma_store(struct mm_struct *mm, struct vm_area_struct *vma)
>          |      ^~~~~~~~~
> 

This was used by fork but was later dropped in the patch set.  I will
fix this for linux-next.

> 
> vim +/vma_store +754 mm/mmap.c
> 
> 37f4270132af31 Liam R. Howlett 2020-07-24  748  
> 37f4270132af31 Liam R. Howlett 2020-07-24  749  /*
> 37f4270132af31 Liam R. Howlett 2020-07-24  750   * vma_store() - Store a given vm_area_struct in the maple tree.
> 37f4270132af31 Liam R. Howlett 2020-07-24  751   * @mm: The struct_mm
> 37f4270132af31 Liam R. Howlett 2020-07-24  752   * @vma: The vm_area_struct to store in the maple tree.
> 37f4270132af31 Liam R. Howlett 2020-07-24  753   */
> 37f4270132af31 Liam R. Howlett 2020-07-24 @754  void vma_store(struct mm_struct *mm, struct vm_area_struct *vma)
> 37f4270132af31 Liam R. Howlett 2020-07-24  755  {
> 37f4270132af31 Liam R. Howlett 2020-07-24  756  	MA_STATE(mas, &mm->mm_mt, 0, 0);
> 37f4270132af31 Liam R. Howlett 2020-07-24  757  
> 37f4270132af31 Liam R. Howlett 2020-07-24  758  	trace_vma_store(vma->vm_mm, vma);
> 37f4270132af31 Liam R. Howlett 2020-07-24  759  	vma_mas_store(vma, &mas);
> 37f4270132af31 Liam R. Howlett 2020-07-24  760  }
> 37f4270132af31 Liam R. Howlett 2020-07-24  761  
> 
> :::::: The code at line 754 was first introduced by commit
> :::::: 37f4270132af31dd08a209799d420f72bfddb49c mm: Start tracking VMAs with maple tree
> 
> :::::: TO: Liam R. Howlett <Liam.Howlett@Oracle.com>
> :::::: CC: Liam R. Howlett <Liam.Howlett@oracle.com>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

      reply	other threads:[~2022-02-24 18:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24  8:51 kernel test robot
2022-02-24 18:23 ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220224182307.oyqkzurlgjq52xnn@revolver \
    --to=liam.howlett@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox