From: Liam Howlett <liam.howlett@oracle.com>
To: kernel test robot <lkp@intel.com>
Cc: "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 6849/7915] arch/riscv/kernel/vdso.c:123:27: error: 'next' undeclared; did you mean 'net'?
Date: Thu, 24 Feb 2022 17:47:03 +0000 [thread overview]
Message-ID: <20220224174702.lnbdo5wwuakcz77u@revolver> (raw)
In-Reply-To: <202202241835.nj71K3LQ-lkp@intel.com>
* kernel test robot <lkp@intel.com> [220224 05:34]:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: fe87c1493391a78238520253b1dd8f80144ced87 [6849/7915] riscv: Use vma iterator for vdso
> config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220224/202202241835.nj71K3LQ-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fe87c1493391a78238520253b1dd8f80144ced87
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout fe87c1493391a78238520253b1dd8f80144ced87
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/riscv/kernel/vdso.c:10:
> arch/riscv/kernel/vdso.c: In function 'vdso_join_timens':
> >> arch/riscv/kernel/vdso.c:123:27: error: 'next' undeclared (first use in this function); did you mean 'net'?
> 123 | for_each_vma(vmi, next) {
> | ^~~~
> include/linux/mm.h:683:49: note: in definition of macro 'for_each_vma'
> 683 | #define for_each_vma(vmi, vma) while ((vma = vma_next(&(vmi))) != NULL)
> | ^~~
> arch/riscv/kernel/vdso.c:123:27: note: each undeclared identifier is reported only once for each function it appears in
> 123 | for_each_vma(vmi, next) {
> | ^~~~
> include/linux/mm.h:683:49: note: in definition of macro 'for_each_vma'
> 683 | #define for_each_vma(vmi, vma) while ((vma = vma_next(&(vmi))) != NULL)
> | ^~~
Thank you, this has already been fixed.
>
>
> vim +123 arch/riscv/kernel/vdso.c
>
> 107
> 108 /*
> 109 * The vvar mapping contains data for a specific time namespace, so when a task
> 110 * changes namespace we must unmap its vvar data for the old namespace.
> 111 * Subsequent faults will map in data for the new namespace.
> 112 *
> 113 * For more details see timens_setup_vdso_data().
> 114 */
> 115 int vdso_join_timens(struct task_struct *task, struct time_namespace *ns)
> 116 {
> 117 struct mm_struct *mm = task->mm;
> 118 struct vm_area_struct *vma;
> 119 VMA_ITERATOR(vmi, mm, 0);
> 120
> 121 mmap_read_lock(mm);
> 122
> > 123 for_each_vma(vmi, next) {
> 124 unsigned long size = vma->vm_end - vma->vm_start;
> 125
> 126 if (vma_is_special_mapping(vma, vdso_info.dm))
> 127 zap_page_range(vma, vma->vm_start, size);
> 128 }
> 129
> 130 mmap_read_unlock(mm);
> 131 return 0;
> 132 }
> 133
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2022-02-24 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 10:33 kernel test robot
2022-02-24 17:47 ` Liam Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224174702.lnbdo5wwuakcz77u@revolver \
--to=liam.howlett@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox