linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: linux-mm <linux-mm@kvack.org>,
	open list <linux-kernel@vger.kernel.org>,
	linux-parisc <linux-parisc@vger.kernel.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>
Subject: Re: [next] mm/mmap.c:1962:25: error: passing argument 1 of 'vma_find' from incompatible pointer type
Date: Thu, 24 Feb 2022 16:34:09 +0000	[thread overview]
Message-ID: <20220224163403.5nrgh753fkwpg3pi@revolver> (raw)
In-Reply-To: <CA+G9fYvdFWYQ4GJkvD9KK8ut=DqHu8MKM-jok+tXo6-HiaPT0g@mail.gmail.com>

* Naresh Kamboju <naresh.kamboju@linaro.org> [220224 09:03]:
> Linux next-20220223 arch parisc builds failed due to following errors.
> Build configs:
>   - gcc-11-defconfig
>   - gcc-11-allnoconfig
>   - gcc-11-tinyconfig
> 
> metadata:
>   git_ref: master
>   git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>   git_sha: d4a0ae62a277377de396850ed4b709b6bd9b7326
>   git_describe: next-20220223
>   arch: parisc
>   toolchain: gcc-11
> 
> 
> Build error:
> -----------
> mm/mmap.c: In function 'expand_upwards':
> mm/mmap.c:1962:25: error: passing argument 1 of 'vma_find' from
> incompatible pointer type [-Werror=incompatible-pointer-types]
>  1962 |         next = vma_find(mm, vma->vm_end);
>       |                         ^~
>       |                         |
>       |                         struct mm_struct *

I have a fix and will push it into my tree for next - at least it fixes the
below tuxmake command.  I am attempting to boot test it.  If anyone wants to
try the fix, I've included it below since it is rather small.

-       next = vma_find(mm, vma->vm_end);
-       if (next && next->vm_start < gap_addr && vma_is_accessible(next)) {
+       next = find_vma_intersection(mm, vma->vm_end, gap_addr);
+       if (next && vma_is_accessible(next)) {


> In file included from arch/parisc/include/asm/cacheflush.h:5,
>                  from include/linux/cacheflush.h:5,
>                  from include/linux/highmem.h:8,
>                  from include/linux/bvec.h:10,
>                  from include/linux/blk_types.h:10,
>                  from include/linux/writeback.h:13,
>                  from include/linux/backing-dev.h:16,
>                  from mm/mmap.c:14:
> include/linux/mm.h:661:54: note: expected 'struct vma_iterator *' but
> argument is of type 'struct mm_struct *'
>   661 | struct vm_area_struct *vma_find(struct vma_iterator *vmi,
> unsigned long max)
>       |                                 ~~~~~~~~~~~~~~~~~~~~~^~~
> cc1: some warnings being treated as errors
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Steps to reproduce:
> ------------------
> # To install tuxmake on your system globally:
> # sudo pip3 install -U tuxmake
> 
> tuxmake --runtime podman --target-arch parisc --toolchain gcc-11
> --kconfig allnoconfig
> 
> 
> --
> Linaro LKFT
> https://lkft.linaro.org
> 
> [1] https://builds.tuxbuild.com/25XO7KdJCJcum36gCorICgGU8C5/

      reply	other threads:[~2022-02-24 20:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 14:02 Naresh Kamboju
2022-02-24 16:34 ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220224163403.5nrgh753fkwpg3pi@revolver \
    --to=liam.howlett@oracle.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox