From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E10EC433EF for ; Thu, 24 Feb 2022 04:41:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CAF68D0002; Wed, 23 Feb 2022 23:41:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47A4C8D0001; Wed, 23 Feb 2022 23:41:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3691F8D0002; Wed, 23 Feb 2022 23:41:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 0CC998D0001 for ; Wed, 23 Feb 2022 23:41:57 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8DB1E181D0815 for ; Thu, 24 Feb 2022 04:41:56 +0000 (UTC) X-FDA: 79176425832.23.2E7884D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id C260240003 for ; Thu, 24 Feb 2022 04:41:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A73EACE1D52; Thu, 24 Feb 2022 04:41:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEE2C340E9; Thu, 24 Feb 2022 04:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1645677711; bh=vuS0NmAC044ZKKLND1Y1u97qpqpWfUXe9v4dMoL9AQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XLhMhz9qF648RsZY748WuMLV3n2sP4IkVX6SQDXdIvpG1TMVIf/dBQkibiZPx/BVe Q4GwLQjWJbc2lXST2bz2POZfzdFKU1O9tGTh257Qu4ZjwAAcAe10S/ykFO3RIDnkm8 dNwIPEAoBVZd0TR1OUq2vIUpk+9UiMqFt0vkD4SI= Date: Wed, 23 Feb 2022 20:41:50 -0800 From: Andrew Morton To: Mike Kravetz Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zhenguo Yao , Liu Yuntao , Dan Carpenter Subject: Re: [PATCH v2] hugetlb: clean up potential spectre issue warnings Message-Id: <20220223204150.5e90910fc40ff869666ad4c3@linux-foundation.org> In-Reply-To: <4bad1923-354d-3858-0339-82df8c090c3f@oracle.com> References: <20220218212946.35441-1-mike.kravetz@oracle.com> <26565cd7-01b0-197c-6ce9-af92f5bc8563@oracle.com> <4bad1923-354d-3858-0339-82df8c090c3f@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C260240003 X-Stat-Signature: qpwcb7bskr1tw6ybs7pcjqfgmknmsdqg Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XLhMhz9q; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1645677715-320871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Feb 2022 13:53:56 -0800 Mike Kravetz wrote: > > gadget as it is a _one_ time early boot call. If there is a scenario > > where this could be really abused then it should be mentioned > > explicitly. > > How about adding this note to the commit message? I have already done that. I added "As Michal pointed out, this is unlikely to be exploitable because it is __init code. But the patch suppresses the warnings."