From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CA3C433FE for ; Wed, 23 Feb 2022 17:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F3E18D002E; Wed, 23 Feb 2022 12:13:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A18C8D0011; Wed, 23 Feb 2022 12:13:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 591128D002E; Wed, 23 Feb 2022 12:13:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 356948D0011 for ; Wed, 23 Feb 2022 12:13:49 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AE8E5181CB178 for ; Wed, 23 Feb 2022 17:13:48 +0000 (UTC) X-FDA: 79174691736.15.59DC68E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 1F439C000D for ; Wed, 23 Feb 2022 17:13:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13016B8210A; Wed, 23 Feb 2022 17:13:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF1CFC340E7; Wed, 23 Feb 2022 17:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645636424; bh=Iuzpx3eqNgHmcbEjMXJ+Gh2uRHsMErcCOx9NX8k4XKA=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=B1IyE4COZCZ918sC6snIEXlQ37FWTy+lbsQm8/muHoyWU51r7G2vlkgwMfeeNkkJo LvuUWwWIgzsv0xOKdaQyFEZ5T9cwz0p3p2UmWne4sZvuIY1cz7nOzlDmpLM68zgaJf wXjsKpjrJaOJ0wTGW2ySYzcG2B1OZ4C41Rnt773LWclbltXWyufpzh5CuyF29C8Ly4 o4J2yRRP3b26m03bY+MlZ4y/Ns+5CMzG0cMBTodUAdptqggAuoPAV1RFipqqHELUCq v36YZRyzZKCJFamHLx+pcHWrmQOGNduvvo3l8sf8PSfT/8Y3ARBlwxl1MSbald+nmN R+VI6B8pEJxAA== From: SeongJae Park To: SeongJae Park Cc: Greg KH , akpm@linux-foundation.org, corbet@lwn.net, skhan@linuxfoundation.org, rientjes@google.com, xhao@linux.alibaba.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] mm/damon: Implement a minimal stub for sysfs-based DAMON interface Date: Wed, 23 Feb 2022 17:13:41 +0000 Message-Id: <20220223171341.29010-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220223164513.23089-1-sj@kernel.org> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1F439C000D X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B1IyE4CO; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: myukjr4fda6kbsj4tqwzfp1yw44waic1 X-HE-Tag: 1645636427-627542 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Feb 2022 16:45:13 +0000 SeongJae Park wrote: > On Wed, 23 Feb 2022 17:09:38 +0100 Greg KH wrote: > > > On Wed, Feb 23, 2022 at 03:20:42PM +0000, SeongJae Park wrote: > > > +static struct kobj_attribute damon_sysfs_ul_range_min_attr = > > > + __ATTR(min, 0600, damon_sysfs_ul_range_min_show, > > > + damon_sysfs_ul_range_min_store); > > > + > > > +static struct kobj_attribute damon_sysfs_ul_range_max_attr = > > > + __ATTR(max, 0600, damon_sysfs_ul_range_max_show, > > > + damon_sysfs_ul_range_max_store); > > > > Can you use __ATTR_RW_MODE() instead here and elsewhere? > > Sure, I will, in the next revision. After thinking once more, I realized that it might not so simple. First of all, there are two files having same name in different directories (kdamonds//pid and targets//pid). The files work differently, so I need to use different _show/_store callbacks for them but __ATTR_RW_MODE() wouldn't support the case. Secondly, I'd like to keep the file names short because the meaning of the files can easily inferred from the hierarchy, but want to keep the _show/_store callback names to have prefixes that allows us easily know their meaning and usage even though it makes the name a little bit longer because I don't want to have too much source files for DAMON sysfs interface. Am I missing some of your point? Thanks, SJ [...]