From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5FCC433F5 for ; Wed, 23 Feb 2022 16:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84D5E8D0028; Wed, 23 Feb 2022 11:45:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FCC28D0011; Wed, 23 Feb 2022 11:45:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C5B88D0028; Wed, 23 Feb 2022 11:45:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 447558D0011 for ; Wed, 23 Feb 2022 11:45:19 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id A63291211E5 for ; Wed, 23 Feb 2022 16:45:18 +0000 (UTC) X-FDA: 79174619916.03.FBB3D39 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id A75B24000F for ; Wed, 23 Feb 2022 16:45:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52113609ED; Wed, 23 Feb 2022 16:45:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D716DC340E7; Wed, 23 Feb 2022 16:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645634716; bh=SqOGPss8W5UPV/EirpHZ5v3lVEHrAzC5LHdF1L/Apgc=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=LPNTV0OGyBOD9kwKtRxATg9rqREM5k1tRxwVotYlhajlm8jFiqL9d41bMbaraLgyB Nd9pIix88TJSwGBD0lhHweQJIBhpfq80hZM5/gzQD2Rs5pCHDPoTJux5kwZhvbf8Bj eVAHiZnOFjDEbd54RQosr9yu/pqpxof97V2r0D+h9Cj75oYZbAvie3WVBYYwANsXCy tktlff6RrSBiZRyTMzjoTkw6uoyzJCXKf5x435AFQ6stzE2U28FUVIfjqzKDQkp9/r Oe7a9NzHpfW/0+BxiFNNFPMlcPrxYicL05iW8Ib1dZphNn1G5oPLY5vJl+3W/UnPMe tvoU7VT4zMv1A== From: SeongJae Park To: Greg KH Cc: SeongJae Park , akpm@linux-foundation.org, corbet@lwn.net, skhan@linuxfoundation.org, rientjes@google.com, xhao@linux.alibaba.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/12] mm/damon: Implement a minimal stub for sysfs-based DAMON interface Date: Wed, 23 Feb 2022 16:45:13 +0000 Message-Id: <20220223164513.23089-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Rspamd-Queue-Id: A75B24000F X-Stat-Signature: etw6dp39kberpcwuphrs5qzwc74biz36 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LPNTV0OG; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-HE-Tag: 1645634717-561844 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Feb 2022 17:09:38 +0100 Greg KH wrote: > On Wed, Feb 23, 2022 at 03:20:42PM +0000, SeongJae Park wrote: > > +static struct kobj_attribute damon_sysfs_ul_range_min_attr = > > + __ATTR(min, 0600, damon_sysfs_ul_range_min_show, > > + damon_sysfs_ul_range_min_store); > > + > > +static struct kobj_attribute damon_sysfs_ul_range_max_attr = > > + __ATTR(max, 0600, damon_sysfs_ul_range_max_show, > > + damon_sysfs_ul_range_max_store); > > Can you use __ATTR_RW_MODE() instead here and elsewhere? Sure, I will, in the next revision. Thanks, SJ > > thanks, > > greg k-h >