From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E895C43217 for ; Wed, 23 Feb 2022 16:44:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6CB58D0027; Wed, 23 Feb 2022 11:44:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C1DE18D0011; Wed, 23 Feb 2022 11:44:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96B48D0027; Wed, 23 Feb 2022 11:44:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 85F608D0011 for ; Wed, 23 Feb 2022 11:44:46 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0D2DC181AF5C3 for ; Wed, 23 Feb 2022 16:44:46 +0000 (UTC) X-FDA: 79174618572.29.AD3AABA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 89E85160004 for ; Wed, 23 Feb 2022 16:44:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88D6C60A0F; Wed, 23 Feb 2022 16:44:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF5E2C340E7; Wed, 23 Feb 2022 16:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645634684; bh=yNzZkkA2UtpmBgQG99OdPqjIkEh3BZ5nLjxVqvHizPM=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=My1iUTPnePhE6rx/netU/jwR/kHe9OK12+OnID8BVXpxUW4FKMUKVALhxRwaDnNUX KJ0Q4LpXtHVTapQY34W7LvJbCCdt4/JS7J5YBNWtKbjcp71YKQKTEzdJ4EH+w6wfxy J5SSvsO7xpD2im9Vtw5oG5k4uMWDmACxbvap9HMwXElVFO15//1Snj0W+Z8H073erL SbMbJgaSe7gvllLPDC4gCHcgo26ueaHL785ZnwGlVPfhVPva3drI77u6c064DuvzN7 n83RdpA3jBmFhBZkh23FBc74GETIoQTCV6iWwwxkSUDwDTex7+jOSeflF1xhATjYBN 7XOILwVCUdleQ== From: SeongJae Park To: Greg KH Cc: SeongJae Park , akpm@linux-foundation.org, corbet@lwn.net, skhan@linuxfoundation.org, rientjes@google.com, xhao@linux.alibaba.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/12] Introduce DAMON sysfs interface Date: Wed, 23 Feb 2022 16:44:40 +0000 Message-Id: <20220223164440.23030-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Rspamd-Queue-Id: 89E85160004 X-Stat-Signature: gs1qogu6bkd3u91u7zfcsrynrjfp6gbz X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=My1iUTPn; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-HE-Tag: 1645634685-102558 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Feb 2022 17:07:20 +0100 Greg KH wrote: > On Wed, Feb 23, 2022 at 03:20:39PM +0000, SeongJae Park wrote: > > Chages from Previous Version (RFC) > > ================================== > > > > Compared to the RFC version of this patchset > > (https://lore.kernel.org/linux-mm/20220217161938.8874-1-sj@kernel.org/), this > > version contains below changes. > > > > - Implement all DAMON debugfs interface providing features > > - Writeup documents > > - Add more selftests > > > > Introduction > > ============ > > > > DAMON's debugfs-based user interface (DAMON_DBGFS) served very well, so far. > > However, it unnecessarily depends on debugfs, while DAMON is not aimed to be > > used for only debugging. Also, the interface receives multiple values via one > > file. For example, schemes file receives 18 values. As a result, it is > > inefficient, hard to be used, and difficult to be extended. Especially, > > keeping backward compatibility of user space tools is getting only challenging. > > It would be better to implement another reliable and flexible interface and > > deprecate DAMON_DBGFS in long term. [...] > > > > SeongJae Park (12): > > mm/damon/core: Allow non-exclusive DAMON start/stop > > mm/damon/core: Add number of each enum type values > > mm/damon: Implement a minimal stub for sysfs-based DAMON interface > > mm/damon/sysfs: Link DAMON for virtual address spaces monitoring > > mm/damon/sysfs: Support physical address space monitoring > > mm/damon/sysfs: Support DAMON-based Operation Schemes > > mm/damon/sysfs: Support DAMOS quotas > > mm/damon/sysfs: Support schemes prioritization weights > > mm/damon/sysfs: Support DAMOS watermarks > > mm/damon/sysfs: Support DAMOS stats > > selftests/damon: Add a test for DAMON sysfs interface > > Docs/admin-guide/mm/damon/usage: Document DAMON sysfs interface > > > > Documentation/admin-guide/mm/damon/usage.rst | 349 ++- > > include/linux/damon.h | 6 +- > > mm/damon/Kconfig | 7 + > > mm/damon/Makefile | 1 + > > mm/damon/core.c | 23 +- > > mm/damon/dbgfs.c | 2 +- > > mm/damon/reclaim.c | 2 +- > > mm/damon/sysfs.c | 2684 ++++++++++++++++++ > > tools/testing/selftests/damon/Makefile | 1 + > > tools/testing/selftests/damon/sysfs.sh | 306 ++ > > 10 files changed, 3364 insertions(+), 17 deletions(-) > > create mode 100644 mm/damon/sysfs.c > > create mode 100755 tools/testing/selftests/damon/sysfs.sh > > sysfs files need to be documented in Documentation/ABI/ which is where > our tools look for them (have you run scripts/get_abi.pl with your code > in the kernel?) > > Please fix this up to use that format so we can then verify that you are > using sysfs correctly. Sure, I will do so in the next version. Thanks, SJ > > thanks, > > greg k-h