From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBDBC433F5 for ; Wed, 23 Feb 2022 07:12:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 623598D0003; Wed, 23 Feb 2022 02:12:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3118D0001; Wed, 23 Feb 2022 02:12:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49B508D0003; Wed, 23 Feb 2022 02:12:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 3C7518D0001 for ; Wed, 23 Feb 2022 02:12:41 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D67D8181CB14A for ; Wed, 23 Feb 2022 07:12:40 +0000 (UTC) X-FDA: 79173176880.12.56E9B7D Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 17024100003 for ; Wed, 23 Feb 2022 07:12:39 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id z2so9191855plg.8 for ; Tue, 22 Feb 2022 23:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ajou.ac.kr; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6uuzVN1UJ0wlPIBvc5RuIVNuH89a9Tcx9jYvk/QnraQ=; b=UqcYI26jPzt/A9W+XVxcNMYGU4H6L8u+7eyPS2QINEXDuB96ft/dKBVQG4O70cqeZa yhZUAqRDIRqT9UKPAtyrP+euVjV32odYSAEn21NK2goWj6cuuNkMbECCMKw9R1/xGVjB rfouz12S64OtWfovNfGWyH0OCbInN77kWZSkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6uuzVN1UJ0wlPIBvc5RuIVNuH89a9Tcx9jYvk/QnraQ=; b=Uh7+IK7GqlaFALZ/ySEv6opBk/GrUcN2DOXpawrq8ACA3Mp65DQOK4P/xt9ms81EC1 9MP7zYbULU4WB3NC4LqiZk+6FnA0PL7w26B+7oExC/Y6RVi/M5X/YbTMhBsqzs0rpF3N V2WKwxRPaeaejKwU2q8tGlF6gZOSKTLat2sDaufNN/EBwskoTizdbqBzhwjpt18aQXYh Ri0lEwiIpCYdwKivMRE7g/oO8nR862kV9C/kGvEd0Gfd6bKeRAW6kOh2QQnEre/R+X3r +NIl9q/zOhCfU1LFQ8yEnkH0NtoUJ/R2W2h5XNeK39bTyifJDxBxqszBQzyJWxhD+vwG 8cCg== X-Gm-Message-State: AOAM532hkWrCEPkg+0HF62IFU60qSG+mbB1V9ZlplcGvJ/PrlKKPdYgx zW8DT4m2WTpRxlo9nn/aRA8KFw== X-Google-Smtp-Source: ABdhPJzghEaT60ySPQIKC2OuUaWnP3XDsnfAPCp2Ui70QAAvJUKtBFDZ+cklkNBA18kDIcbu6Wsn3w== X-Received: by 2002:a17:90a:67c3:b0:1bc:9cdf:1ee9 with SMTP id g3-20020a17090a67c300b001bc9cdf1ee9mr1010955pjm.203.1645600359035; Tue, 22 Feb 2022 23:12:39 -0800 (PST) Received: from swarm08 ([210.107.197.32]) by smtp.gmail.com with ESMTPSA id u21sm1732193pjr.46.2022.02.22.23.12.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Feb 2022 23:12:38 -0800 (PST) Date: Wed, 23 Feb 2022 16:12:32 +0900 From: Jonghyeon Kim To: SeongJae Park Cc: Jonghyeon Kim , Jonathan.Cameron@Huawei.com, amit@kernel.org, benh@kernel.crashing.org, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, foersleo@amazon.de, gthelen@google.com, markubo@amazon.de, rientjes@google.com, shakeelb@google.com, shuah@kernel.org, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 0/3] Rebase DAMON_RECALIM for NUMA system Message-ID: <20220223071232.GD6270@swarm08> References: <20220218102611.31895-1-tome01@ajou.ac.kr> <20220222095302.7859-1-sj@kernel.org> <20220223051146.GA4530@swarm08> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220223051146.GA4530@swarm08> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 17024100003 X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ajou.ac.kr header.s=google header.b=UqcYI26j; spf=pass (imf14.hostedemail.com: domain of tome01@ajou.ac.kr designates 209.85.214.179 as permitted sender) smtp.mailfrom=tome01@ajou.ac.kr; dmarc=pass (policy=reject) header.from=ajou.ac.kr X-Stat-Signature: 4fonr1waxhm84sxxeb6goumhqenoy4u5 X-HE-Tag: 1645600359-669815 X-Bogosity: Ham, tests=bogofilter, spamicity=0.030548, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 23, 2022 at 02:11:46PM +0900, Jonghyeon Kim wrote: > On Tue, Feb 22, 2022 at 09:53:02AM +0000, SeongJae Park wrote: > > Hello Jonghyeon, > > > > On Fri, 18 Feb 2022 19:26:08 +0900 Jonghyeon Kim wrote: > > > > > > > > Current DAMON_RECALIM is not compatible with the NUMA memory system. To > > > proactively reclaim memory, DAMON_RECLAIM kernel thread(kdamond) has to wake up > > > before kswapd does reclaim memory. However, the current watermark for proactive > > > reclamation is based on entire system free memory. So, though the one memory > > > node is fully used, kdamond is not waked up. > > > > > > These patches clarify watermarks of DAMOS and enable monitoring per NUMA node > > > proactive reclamation on DAMON_RECLAIM. > > > > The high level concept of this patchset looks good to me. Nevertheless, maybe > > there is some rooms for improvement. I left some comments on patches. > > > > > > Thanks, > > SJ > > > > Hello SeongJae, > > Thanks for your patient comments about these patches. I will clean up and > develop these patches including your suggestion and correction in next version. > > > Jonghyeon