From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82463C433F5 for ; Tue, 22 Feb 2022 15:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10E0C8D0002; Tue, 22 Feb 2022 10:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BF018D0001; Tue, 22 Feb 2022 10:59:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEE7F8D0002; Tue, 22 Feb 2022 10:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id DEADB8D0001 for ; Tue, 22 Feb 2022 10:59:09 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 99DFB9BBD7 for ; Tue, 22 Feb 2022 15:59:09 +0000 (UTC) X-FDA: 79170874818.13.E08D4DC Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id 0B23A40004 for ; Tue, 22 Feb 2022 15:59:08 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6721B68AFE; Tue, 22 Feb 2022 16:59:04 +0100 (CET) Date: Tue, 22 Feb 2022 16:59:04 +0100 From: Christoph Hellwig To: Baoquan He Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@aculab.com, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 1/2] dma-mapping: check dma_mask for streaming mapping allocs Message-ID: <20220222155904.GA13323@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-22-bhe@redhat.com> <20220219071730.GG26711@lst.de> <20220220084044.GC93179@MiWiFi-R3L-srv> <20220222084530.GA6210@lst.de> <20220222131120.GB10093@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=none (imf11.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0B23A40004 X-Stat-Signature: sdmd4coocmm8kqp8psdfsutij557j6io X-HE-Tag: 1645545548-465973 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 22, 2022 at 09:41:43PM +0800, Baoquan He wrote: > For newly added streaming mapping APIs, the internal core function > __dma_alloc_pages() should check dev->dma_mask, but not > ev->coherent_dma_mask which is for coherent mapping. No, this is wrong. dev->coherent_dma_mask is and should be used here. > > > Meanwhile, just filter out gfp flags if they are any of > __GFP_DMA, __GFP_DMA32 and __GFP_HIGHMEM, but not fail it. This change > makes it consistent with coherent mapping allocs. This is wrong as well. We want to eventually fail dma_alloc_coherent for these, too. It just needs more work.