From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C6AC433F5 for ; Tue, 22 Feb 2022 08:45:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7FFE8D0002; Tue, 22 Feb 2022 03:45:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F838D0001; Tue, 22 Feb 2022 03:45:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91FC78D0002; Tue, 22 Feb 2022 03:45:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 844358D0001 for ; Tue, 22 Feb 2022 03:45:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 38356181BD7B5 for ; Tue, 22 Feb 2022 08:45:34 +0000 (UTC) X-FDA: 79169782188.30.DD0AC60 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP id 8859220003 for ; Tue, 22 Feb 2022 08:45:33 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id BE08D68B05; Tue, 22 Feb 2022 09:45:30 +0100 (CET) Date: Tue, 22 Feb 2022 09:45:30 +0100 From: Christoph Hellwig To: Baoquan He Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@aculab.com, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 21/22] mmc: wbsd: Use dma_alloc_noncoherent() for dma buffer Message-ID: <20220222084530.GA6210@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-22-bhe@redhat.com> <20220219071730.GG26711@lst.de> <20220220084044.GC93179@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220220084044.GC93179@MiWiFi-R3L-srv> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8859220003 X-Stat-Signature: 8hudfzbmb3ztdrbh3jgpxrt8owrjxxj9 Authentication-Results: imf13.hostedemail.com; dkim=none; spf=none (imf13.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-HE-Tag: 1645519533-131032 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 20, 2022 at 04:40:44PM +0800, Baoquan He wrote: > On 02/19/22 at 08:17am, Christoph Hellwig wrote: > > On Sat, Feb 19, 2022 at 08:52:20AM +0800, Baoquan He wrote: > > > if (request_dma(dma, DRIVER_NAME)) > > > goto err; > > > > > > + dma_set_mask_and_coherent(mmc_dev(host->mmc), DMA_BIT_MASK(24)); > > > > This also sets the streaming mask, but the driver doesn't seem to make > > use of that. Please document it in the commit log. > > Thanks for reviewing. I will change it to dma_set_mask(), and describe > this change in patch log. No, if you change it, it should be dma_set_coherent_mask only as it is not using streaming mappings. I suspect dma_set_mask_and_coherent is the right thing if the driver ever wants to use streaming mapping, it would just need to be documented in the commit message.