From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A93C433EF for ; Sun, 20 Feb 2022 02:06:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A68F86B0072; Sat, 19 Feb 2022 21:06:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A179F6B0073; Sat, 19 Feb 2022 21:06:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8FC6B0074; Sat, 19 Feb 2022 21:06:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 791126B0072 for ; Sat, 19 Feb 2022 21:06:55 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3358D96343 for ; Sun, 20 Feb 2022 02:06:55 +0000 (UTC) X-FDA: 79161519990.16.28BF934 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id C3A3F40003 for ; Sun, 20 Feb 2022 02:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645322783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u35piiWPohqcpYYdwIsCVmh/d8XqMR6334fza7B3jzM=; b=TZtul7ddFQY5D91SqIaOIkRM9hGCHphTI7v5iQ1HwRVt8J0YxWOr+meD1RfIXrh+74+VUC jQdvdbcWEqKPLPzJgwSTncstx4gOPIbhceyBDgo/LzX1ImyKqLkZu/9FoGEw6BQsnA57ae +fK+flNrwNh0GRBAZfMhEDADfvQMrqw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645322814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u35piiWPohqcpYYdwIsCVmh/d8XqMR6334fza7B3jzM=; b=Yc2jPqrHQHmYk48CgcI9GChZirgMNt7UbzrJqQSCF0bkiHsOPr0lzj6n+VGSNL0g+wtoDK 6WoaR945FncwyC953XTzsZaDtXlz3bwPIGj9xYPZSoyTN9h1kHHW7OAzbWzl6gc/LAD4kI /kX7oNbT1Kjju0uRQsrNnuwZnSlazNg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-368-ZCsigVPTOsm5Z-VVgbZzmw-1; Sat, 19 Feb 2022 21:06:19 -0500 X-MC-Unique: ZCsigVPTOsm5Z-VVgbZzmw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A145E1898290; Sun, 20 Feb 2022 02:06:16 +0000 (UTC) Received: from localhost (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DDD21971B; Sun, 20 Feb 2022 02:06:05 +0000 (UTC) Date: Sun, 20 Feb 2022 10:06:01 +0800 From: Baoquan He To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@aculab.com, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 17/22] net: marvell: prestera: Don't use GFP_DMA when calling dma_pool_alloc() Message-ID: <20220220020601.GB93179@MiWiFi-R3L-srv> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-18-bhe@redhat.com> <20220218205408.45d1085e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218205408.45d1085e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C3A3F40003 X-Stat-Signature: i6oft8mdh4y8c74enrugaqrgc4bfmt85 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TZtul7dd; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Yc2jPqrH; spf=none (imf04.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1645322814-147387 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/18/22 at 08:54pm, Jakub Kicinski wrote: > On Sat, 19 Feb 2022 08:52:16 +0800 Baoquan He wrote: > > dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer, > > so it's redundent to specify GFP_DMA when calling. > > > > Signed-off-by: Baoquan He > > This and the other two netdev patches in the series are perfectly > cleanups reasonable even outside of the larger context. > > Please repost those separately and make sure you CC the maintainers > of the drivers. Thanks for reviewing. I am not familiar with netdev and network patch posting rule. There are 4 patches altogether related to netdev as below, Will repost them to the relevant netdev mailinglist and maintainers. [PATCH 19/22] ethernet: rocker: Use dma_alloc_noncoherent() for dma buffer [PATCH 18/22] net: ethernet: mtk-star-emac: Don't use GFP_DMA when calling dmam_alloc_coherent() [PATCH 17/22] net: marvell: prestera: Don't use GFP_DMA when calling dma_pool_alloc() [PATCH 02/22] net: moxa: Don't use GFP_DMA when calling dma_alloc_coherent()