From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F11BC433EF for ; Sat, 19 Feb 2022 23:58:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A79E6B0071; Sat, 19 Feb 2022 18:58:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 755B86B0073; Sat, 19 Feb 2022 18:58:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61CB36B0074; Sat, 19 Feb 2022 18:58:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 52F426B0071 for ; Sat, 19 Feb 2022 18:58:55 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F15CE9ACB9 for ; Sat, 19 Feb 2022 23:58:54 +0000 (UTC) X-FDA: 79161197430.10.C391E51 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 7A546C0006 for ; Sat, 19 Feb 2022 23:58:54 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id y11so5438502pfa.6 for ; Sat, 19 Feb 2022 15:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pyKnh0rifNC4U8/SpWhjiS3uUcC5kmVNLLaPc0IhXvY=; b=eFv9LIHn5T7yu7SXdfr1xRt6PH8DYtfvvMqPlhlsZ6bZC6Gwo4CnvRkxkLGP4v1/za xH7WDZlsGzhKXMPVZxNtJvfV97TeYC/+z2zTWMOzSyPurTe9RIkmSZRk2tNYowdcG0FS fqY5kUxdDE9sZFT3ljh+x03Lnvopm2Tk7vorM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyKnh0rifNC4U8/SpWhjiS3uUcC5kmVNLLaPc0IhXvY=; b=77b2GfdjPjuDJR3nRSNjQI450TMaatO/RThi9bhHDeyColWHt80TvF/E0WuLKfFjrZ FC0fN0wl4hUGj5znyPvQi+Z2pADEyM4nT60uuH+ovVhKuaOrfNOHREv8sMTAjJtrvqW+ WIpHIadwDMEve4dRqiyZAUuDvZGqlt53BYCYW8Sb8YSgQqSwUV68m3PPMeWsRaSOlGCR 201V87rYgrrLnt0aXfpGYkRB+qIyQNhCMWCFXU8yd2scYJz3/6EvFVblGi7VwNwJR3DO b1Nm5vEUQK/Xar01STteNYQSpwAMNSuqqr1MClFEH2Gy0UrR9jy6As1ezfok5othKVpO wm8w== X-Gm-Message-State: AOAM532ulxWow40X3k1VvZt3sAsTpCET3e6QaSRRVh8FhMmxpPVmveo6 SUYB22KzFUk8zxk0kolQvwKG5w== X-Google-Smtp-Source: ABdhPJz2B7x/obkYAxIzuuWmK0eIrem1Iyubh1rAOvTpZqyu2/XzDhnjlP1qJpC13eAFz3bW7Wje1A== X-Received: by 2002:a05:6a00:cd3:b0:4df:7b9e:2557 with SMTP id b19-20020a056a000cd300b004df7b9e2557mr14045768pfv.25.1645315133327; Sat, 19 Feb 2022 15:58:53 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u11sm7756421pfi.71.2022.02.19.15.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Feb 2022 15:58:52 -0800 (PST) Date: Sat, 19 Feb 2022 15:58:51 -0800 From: Kees Cook To: Nick Desaulniers Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable , Daniel Micay , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Nathan Chancellor , linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH] slab: remove __alloc_size attribute from __kmalloc_track_caller Message-ID: <202202191558.11C173F04@keescook> References: <20220218131358.3032912-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=eFv9LIHn; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7A546C0006 X-Stat-Signature: ben35jti6g7ae4oeh9qixcnyceorigws X-HE-Tag: 1645315134-526620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 18, 2022 at 09:19:51AM -0800, Nick Desaulniers wrote: > On Fri, Feb 18, 2022 at 5:14 AM Greg Kroah-Hartman > wrote: > > > > Commit c37495d6254c ("slab: add __alloc_size attributes for better > > bounds checking") added __alloc_size attributes to a bunch of kmalloc > > function prototypes. Unfortunately the change to __kmalloc_track_caller > > seems to cause clang to generate broken code and the first time this is > > called when booting, the box will crash. > > > > While the compiler problems are being reworked and attempted to be > > solved, let's just drop the attribute to solve the issue now. Once it > > is resolved it can be added back. > > Sorry about the mess; we'll get it cleaned up! > Acked-by: Nick Desaulniers > Link: https://github.com/ClangBuiltLinux/linux/issues/1599 Thanks for the issue link! Acked-by: Kees Cook -- Kees Cook