From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CE8C433F5 for ; Sat, 19 Feb 2022 07:13:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D09D6B0074; Sat, 19 Feb 2022 02:13:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17FFC6B0078; Sat, 19 Feb 2022 02:13:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06F806B007B; Sat, 19 Feb 2022 02:13:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id ED3E06B0074 for ; Sat, 19 Feb 2022 02:13:16 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A447B8249980 for ; Sat, 19 Feb 2022 07:13:16 +0000 (UTC) X-FDA: 79158663192.08.5A98E6C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 25CA440006 for ; Sat, 19 Feb 2022 07:13:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 825A868BEB; Sat, 19 Feb 2022 08:13:13 +0100 (CET) Date: Sat, 19 Feb 2022 08:13:13 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 16/22] usb: udc: lpc32xx: Don't use GFP_DMA when calling dma_pool_alloc() Message-ID: <20220219071313.GB26711@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-17-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-17-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: 5fff5dbom6b9199jbk3ugta7kwbhtb1j X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 25CA440006 X-HE-Tag: 1645254795-276760 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 08:52:15AM +0800, Baoquan He wrote: > dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer, > so it's redundent to specify GFP_DMA when calling. Looks good, Reviewed-by: Christoph Hellwig