From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B74C433F5 for ; Sat, 19 Feb 2022 07:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D4FC6B007B; Sat, 19 Feb 2022 02:09:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 184546B007E; Sat, 19 Feb 2022 02:09:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 073E56B0080; Sat, 19 Feb 2022 02:09:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id EDA8D6B007B for ; Sat, 19 Feb 2022 02:09:26 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1D08181AEF1F for ; Sat, 19 Feb 2022 07:09:26 +0000 (UTC) X-FDA: 79158653532.09.BA9E37D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 35CE280006 for ; Sat, 19 Feb 2022 07:09:26 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9BF7868D05; Sat, 19 Feb 2022 08:09:23 +0100 (CET) Date: Sat, 19 Feb 2022 08:09:23 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 09/22] usb: cdns3: Don't use GFP_DMA when calling dma_alloc_coherent() Message-ID: <20220219070923.GI26505@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-10-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-10-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 35CE280006 X-Stat-Signature: uqx5d81g7wh91d3u4w6huynem3t9wwn4 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam03 X-HE-Tag: 1645254566-216088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 08:52:08AM +0800, Baoquan He wrote: > dma_alloc_coherent() allocates dma buffer with device's addressing > limitation in mind. It's redundent to specify GFP_DMA when calling > dma_alloc_coherent(). replace it with GFP_KERNEL. Plase avoid the overly long line. The rest looks good.