From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5C8C433F5 for ; Sat, 19 Feb 2022 04:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D57896B0074; Fri, 18 Feb 2022 23:54:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D062C6B0075; Fri, 18 Feb 2022 23:54:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCDE76B0078; Fri, 18 Feb 2022 23:54:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id AEECB6B0074 for ; Fri, 18 Feb 2022 23:54:12 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5A34B9C9E1 for ; Sat, 19 Feb 2022 04:54:12 +0000 (UTC) X-FDA: 79158312744.26.3340618 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id C4FD6180006 for ; Sat, 19 Feb 2022 04:54:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB9B060A3D; Sat, 19 Feb 2022 04:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 503B4C004E1; Sat, 19 Feb 2022 04:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645246450; bh=h2795+8GYlVPXKPJ5I2QLnhGfDjELLMFhyd7g3oIiok=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C67Z4thZk4x8k2ihFzAMQ+CzkTAXiWLj6ky0jZolGsq3PSQ7iava14DtHEJK9pH8B XBWY9BP7ryDDq8UGjL1UMl/3hjyB6WBIhxuMRfXKxnBtnSe3Lux6wJ70qrFBbSs0O7 dMHM2nTL3gxW8+4lpm+3GQEd8WNoeZtGmrB9dV+AHS3zvH6/Yw32O7JIZtLxygcZRU IaWc5U9rGgZeSRBmT0sNNjVXq3Jq8m0QxOwb4M7JbMQ+PBvvI/P+6HOEqR1l91CyQp sswC45Mxukh0p6GwgJMW54eRsq9L/16ViQBFP4BKw80bWblnhvD1QjDtzFgdrhh4At OVHKaaTAdvtoA== Date: Fri, 18 Feb 2022 20:54:08 -0800 From: Jakub Kicinski To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 17/22] net: marvell: prestera: Don't use GFP_DMA when calling dma_pool_alloc() Message-ID: <20220218205408.45d1085e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220219005221.634-18-bhe@redhat.com> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-18-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zodq3hfj7xwf1g78bhjzyez1g71azq73 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C67Z4thZ; spf=pass (imf16.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C4FD6180006 X-HE-Tag: 1645246451-327469 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 19 Feb 2022 08:52:16 +0800 Baoquan He wrote: > dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer, > so it's redundent to specify GFP_DMA when calling. > > Signed-off-by: Baoquan He This and the other two netdev patches in the series are perfectly cleanups reasonable even outside of the larger context. Please repost those separately and make sure you CC the maintainers of the drivers.