From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F849C433F5 for ; Fri, 18 Feb 2022 19:23:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2B506B0075; Fri, 18 Feb 2022 14:23:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDAB96B0078; Fri, 18 Feb 2022 14:23:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA32C6B007B; Fri, 18 Feb 2022 14:23:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id ABAED6B0075 for ; Fri, 18 Feb 2022 14:23:10 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6B3E09EB3B for ; Fri, 18 Feb 2022 19:23:10 +0000 (UTC) X-FDA: 79156873740.31.1F10B57 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id C2F084000E for ; Fri, 18 Feb 2022 19:23:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D01E9CE3311; Fri, 18 Feb 2022 19:23:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF58C340E9; Fri, 18 Feb 2022 19:23:02 +0000 (UTC) Date: Fri, 18 Feb 2022 14:23:01 -0500 From: Steven Rostedt To: Matthew Wilcox Cc: Jakub =?UTF-8?B?TWF0xJtuYQ==?= , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org, mgorman@techsingularity.net, liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name, riel@surriel.com, peterz@infradead.org Subject: Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges Message-ID: <20220218142301.0b5731e1@gandalf.local.home> In-Reply-To: References: <20220218122019.130274-1-matenajakub@gmail.com> <20220218122019.130274-5-matenajakub@gmail.com> <20220218130920.5902d967@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=pna2=TB=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=pna2=TB=goodmis.org=rostedt@kernel.org" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C2F084000E X-Stat-Signature: eomyx4a7gnc51ntu9yomp8eb9a75u7ku X-HE-Tag: 1645212189-324545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Feb 2022 18:46:29 +0000 Matthew Wilcox wrote: > On Fri, Feb 18, 2022 at 01:09:20PM -0500, Steven Rostedt wrote: > > Please indent the above better. That is: > > > > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) > > + (merge_next == AV_MERGE_DIFFERENT) > > + (merge_both == AV_MERGE_DIFFERENT); > > I thought our coding style preferred trailing operators; that is: > > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) + > (merge_next == AV_MERGE_DIFFERENT) + > (merge_both == AV_MERGE_DIFFERENT); I'm OK with either. I just can't handle the original. -- Steve