From: Steven Rostedt <rostedt@goodmis.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Jakub Matěna" <matenajakub@gmail.com>,
linux-mm@kvack.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org,
mgorman@techsingularity.net, liam.howlett@oracle.com,
hughd@google.com, kirill@shutemov.name, riel@surriel.com,
peterz@infradead.org
Subject: Re: [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges
Date: Fri, 18 Feb 2022 14:23:01 -0500 [thread overview]
Message-ID: <20220218142301.0b5731e1@gandalf.local.home> (raw)
In-Reply-To: <Yg/phVScjJCLsGuC@casper.infradead.org>
On Fri, 18 Feb 2022 18:46:29 +0000
Matthew Wilcox <willy@infradead.org> wrote:
> On Fri, Feb 18, 2022 at 01:09:20PM -0500, Steven Rostedt wrote:
> > Please indent the above better. That is:
> >
> > __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT)
> > + (merge_next == AV_MERGE_DIFFERENT)
> > + (merge_both == AV_MERGE_DIFFERENT);
>
> I thought our coding style preferred trailing operators; that is:
>
> __entry->diff_count = (merge_prev == AV_MERGE_DIFFERENT) +
> (merge_next == AV_MERGE_DIFFERENT) +
> (merge_both == AV_MERGE_DIFFERENT);
I'm OK with either. I just can't handle the original.
-- Steve
next prev parent reply other threads:[~2022-02-18 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 12:20 [RFC PATCH 0/4] Removing limitations of merging anonymous VMAs Jakub Matěna
2022-02-18 12:20 ` [RFC PATCH 1/4] [PATCH 1/4] mm: refactor of vma_merge() Jakub Matěna
2022-02-18 19:43 ` Liam Howlett
2022-02-25 14:26 ` Jakub Matěna
2022-02-18 12:20 ` [RFC PATCH 2/4] [PATCH 2/4] mm: adjust page offset in mremap Jakub Matěna
2022-02-18 19:50 ` Liam Howlett
2022-03-01 14:31 ` Jakub Matěna
2022-02-18 12:20 ` [RFC PATCH 3/4] [PATCH 3/4] mm: enable merging of VMAs with different anon_vmas Jakub Matěna
2022-02-18 12:20 ` [RFC PATCH 4/4] [PATCH 4/4] mm: add tracing for VMA merges Jakub Matěna
2022-02-18 18:09 ` Steven Rostedt
2022-02-18 18:46 ` Matthew Wilcox
2022-02-18 19:23 ` Steven Rostedt [this message]
2022-02-18 19:57 ` Liam Howlett
2022-02-25 10:39 ` Vlastimil Babka
2022-02-25 14:07 ` Liam Howlett
2022-02-18 19:21 ` [RFC PATCH 0/4] Removing limitations of merging anonymous VMAs Liam Howlett
2022-02-25 10:31 ` Vlastimil Babka
2022-02-25 14:24 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218142301.0b5731e1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox