From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH v3 8/8] mm/memory-failure.c: remove unnecessary PageTransTail check
Date: Fri, 18 Feb 2022 17:01:18 +0800 [thread overview]
Message-ID: <20220218090118.1105-9-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220218090118.1105-1-linmiaohe@huawei.com>
When we reach here, we're guaranteed to have non-compound page as thp is
already splited. Remove this unnecessary PageTransTail check.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
---
mm/memory-failure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 6bd555f12972..accd1c5d7fa0 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1848,7 +1848,7 @@ int memory_failure(unsigned long pfn, int flags)
* page_lock. We need wait writeback completion for this page or it
* may trigger vfs BUG while evict inode.
*/
- if (!PageTransTail(p) && !PageLRU(p) && !PageWriteback(p))
+ if (!PageLRU(p) && !PageWriteback(p))
goto identify_page_state;
/*
--
2.23.0
prev parent reply other threads:[~2022-02-18 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:01 [PATCH v3 0/8] A few cleanup and fixup patches for memory failure Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 1/8] mm/memory-failure.c: minor clean up for memory_failure_dev_pagemap Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 2/8] mm/memory-failure.c: catch unexpected -EFAULT from vma_address() Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 3/8] mm/memory-failure.c: rework the signaling logic in kill_proc Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 4/8] mm/memory-failure.c: fix race with changing page more robustly Miaohe Lin
2022-02-20 23:43 ` HORIGUCHI NAOYA(堀口 直也)
2022-02-18 9:01 ` [PATCH v3 5/8] mm/memory-failure.c: remove PageSlab check in hwpoison_filter_dev Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 6/8] mm/memory-failure.c: rework the try_to_unmap logic in hwpoison_user_mappings() Miaohe Lin
2022-02-18 9:01 ` [PATCH v3 7/8] mm/memory-failure.c: remove obsolete comment in __soft_offline_page Miaohe Lin
2022-02-18 9:01 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218090118.1105-9-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox