From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61434C433FE for ; Fri, 18 Feb 2022 08:24:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF0C16B0074; Fri, 18 Feb 2022 03:24:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9F206B0075; Fri, 18 Feb 2022 03:24:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8DF76B0078; Fri, 18 Feb 2022 03:24:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 9AEF56B0074 for ; Fri, 18 Feb 2022 03:24:38 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4E9CB180AC320 for ; Fri, 18 Feb 2022 08:24:38 +0000 (UTC) X-FDA: 79155214236.07.BF9EC49 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id B802040004 for ; Fri, 18 Feb 2022 08:24:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F0E72B820CC; Fri, 18 Feb 2022 08:24:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4D9AC340E9; Fri, 18 Feb 2022 08:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645172674; bh=pae/aN5UV9dv8pK4WMcI2r3n2XoZK9a73URkWMOsIU8=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=nPho2b8erTCNwqyeEtsBRpmMOA28WSKNSM80QMXGtOhqnxS2kscFrpozFk8dcvKwY nE7zdwKqDVye4p7zcmikDqBFAlzORK6kp/bxSPS+BgbM2DeBlz1DqdxqRXOgaLB+49 O7keRvG2n1Ptmcq2EEkKETwDL8s8mzTOIkcywNC+qVvzKXi5bFPsUTYbCpQWYK7YNt KxEegVdCS0DfHem1JyXAfAToN3P6yOiqwtSSw//xb7JZj/5zdyeSZZSmMxEfwZWRvL 9dxeR+iTzVorcXVjxdRx8kVjefAY7Us2ULfGSsKh6eYbpa9aB3tLqFYJoZC12BJiIt F1e2fDqDWMDXw== From: SeongJae Park To: Greg KH Cc: SeongJae Park , Yuanchu Xie , Shuah Khan , Markus Boehme , rientjes@google.com, Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/damon: make selftests executable Date: Fri, 18 Feb 2022 08:24:28 +0000 Message-Id: <20220218082428.11699-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B802040004 X-Stat-Signature: 43jj5geqzhz51ppn3yoxds8zutpkts41 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nPho2b8e; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-HE-Tag: 1645172677-745052 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Feb 2022 09:01:11 +0100 Greg KH wrote: > On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: > > Hello Yuanchu, > > > > Thank you for this patch! > > > > On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie wrote: > > > > > The damon selftests do not have the executable bit on. We fix that by > > > setting the x bits on the .sh files similar to other existing shell > > > selftests. > > > > > > Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") > > > Signed-off-by: Yuanchu Xie > > > > Reviewed-by: SeongJae Park > > This type of change does not work outside of git, so why not just make > the tool that calls these scripts not care about the executable bit like > we do for other scripts? Actually, we made kselftest receives scripts having no executable bit[1], though it still prints warning. I guess Yuanchu wants to remove the warning? To remove the warning, simply making kselftest (runner.sh) stop printing the warning message might make more sense. Nevertheless, it's also true that letting some scripts have executable bits while others not looks inconsistent to me. That's why I left the warning message there. Should we remove the warning from kselftest and remove executable bits from other selftest test scripts? Or, let the inconsistency be? I have no real opinion here, so just wanted to hear others' opinion if possible. BTW, similar issue is also in Kconfig's 'shell' macro. For example, 'runst-version.sh' on -mm tree bothered me before[2], and now 'pahole-version.sh'. I might make change in 'scrips/Kconfig/preprocess.c' later. [1] https://lore.kernel.org/linux-kselftest/20210810164534.25902-1-sj38.park@gmail.com/ [2] https://lore.kernel.org/all/20220110085952.6137-1-sj@kernel.org/ Thanks, SJ > > thanks, > > greg k-h