From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70747C433F5 for ; Thu, 17 Feb 2022 15:55:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2BEA6B0074; Thu, 17 Feb 2022 10:55:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB14D6B0075; Thu, 17 Feb 2022 10:55:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2B356B0078; Thu, 17 Feb 2022 10:55:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 92FD56B0074 for ; Thu, 17 Feb 2022 10:55:46 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 53325180A7F86 for ; Thu, 17 Feb 2022 15:55:46 +0000 (UTC) X-FDA: 79152722292.12.E8DFC64 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id B94DD40006 for ; Thu, 17 Feb 2022 15:55:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C84A61F35; Thu, 17 Feb 2022 15:55:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE992C340E8; Thu, 17 Feb 2022 15:55:38 +0000 (UTC) Date: Thu, 17 Feb 2022 10:55:37 -0500 From: Steven Rostedt To: Byungchul Park Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, bfields@fieldses.org, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, axboe@kernel.dk, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jack@suse.com, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com Subject: Re: [PATCH 10/16] dept: Add proc knobs to show stats and dependency graph Message-ID: <20220217105537.0f63861a@gandalf.local.home> In-Reply-To: <1645095472-26530-11-git-send-email-byungchul.park@lge.com> References: <1645095472-26530-1-git-send-email-byungchul.park@lge.com> <1645095472-26530-11-git-send-email-byungchul.park@lge.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B94DD40006 X-Stat-Signature: 3jm491pb3fxor7ajp75ydm33mycc9kfj X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of "SRS0=CucC=TA=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=CucC=TA=goodmis.org=rostedt@kernel.org" X-HE-Tag: 1645113345-174253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 17 Feb 2022 19:57:46 +0900 Byungchul Park wrote: > +static int __init dept_proc_init(void) > +{ > + proc_create_seq("dept_deps", S_IRUSR, NULL, &dept_deps_ops); > + proc_create_single("dept_stats", S_IRUSR, NULL, dept_stats_show); > + return 0; > +} > + > +__initcall(dept_proc_init); > + And git complains about this extra line at the end of the file too. -- Steve