From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3ACC433F5 for ; Tue, 15 Feb 2022 16:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 365CB6B0078; Tue, 15 Feb 2022 11:07:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3142F6B007B; Tue, 15 Feb 2022 11:07:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DBE66B007D; Tue, 15 Feb 2022 11:07:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 0EB836B0078 for ; Tue, 15 Feb 2022 11:07:02 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D10B7237F7 for ; Tue, 15 Feb 2022 16:07:01 +0000 (UTC) X-FDA: 79145493042.02.F9BA957 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 56E7E18002F for ; Tue, 15 Feb 2022 16:07:01 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id l8so7431424pls.7 for ; Tue, 15 Feb 2022 08:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vyO09UbxJeRvoJPXaZeuEPEmDAtin+d+KKe2VrtUaUo=; b=k6dGMBXjj16JgvtRS/W1l6Q4I2nZDtQcAdycCp9Yomvd6JZnH2zqPlxIg+g+ZPVwSz Yd2M1LVjLDjA37krskwjCpbidnONcAVHIcSbAjYLFVZbM5iGekAEKyRZZ7xCywxW3nBM 4HP4E451gdn725+Vgz91Q6TCzCawlBmVlldfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vyO09UbxJeRvoJPXaZeuEPEmDAtin+d+KKe2VrtUaUo=; b=N6wc4vUOSCVn5BEFujjuxM1mNi8kOZds7LRweIeagMWcUkBKVctZmYyLn3Nolc+P6l MCnNUlFhj9/K5EOphhTjJpxVfA5XPRpUjSp4AwkPhy2A/8DNXaOtyUC2OU6e1Rw5H1XC syHaMACwhOcc6GzgL8ukTIWMiUGvU03O5kYahaOhL810gxVjZh6LXPBC1PMM+xdrep3S /lP3RDjDetxTHChQ316ZprxdTVMyw4sjv7IRaAsdNkfDEtWxKVL9w/s7pRt1WHCj8vCs EAT5DTymL9fFDeMxVr8kROLB5BgBhJzXYIU/PZtOI0vCKvfxh68KYzlPhfdl+idUYDRI rNGQ== X-Gm-Message-State: AOAM531IJxUlXmhUISpnYUtNYRyCUkeszFYHpORBzq/3TriDzRPgfQ+A HWz4qswCwpCy5lI9Av9V1KerKw== X-Google-Smtp-Source: ABdhPJySTpQ67R+nuQyJJfrGZTBLhUE5/ijHpxyRKCqjoqAnDBf2qQYFgmJer9uiO3sFYsKqwhcw6g== X-Received: by 2002:a17:902:cec5:: with SMTP id d5mr4782522plg.96.1644941220276; Tue, 15 Feb 2022 08:07:00 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i17sm3101014pgv.8.2022.02.15.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 08:06:59 -0800 (PST) Date: Tue, 15 Feb 2022 08:06:59 -0800 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 01/13] powerpc: Fix 'sparse' checking on PPC64le Message-ID: <202202150806.66CC906@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: umnnwz5b3c37rxdy1tt6isk5fna9dnxz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 56E7E18002F Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=k6dGMBXj; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspam-User: X-HE-Tag: 1644941221-753008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 15, 2022 at 01:40:56PM +0100, Christophe Leroy wrote: > 'sparse' is architecture agnostic and knows nothing about ELF ABI > version. > > Just like it gets arch and powerpc type and endian from Makefile, > it also need to get _CALL_ELF from there, otherwise it won't set > PPC64_ELF_ABI_v2 macro for PPC64le and won't check the correct code. > > Signed-off-by: Christophe Leroy Reviewed-by: Kees Cook -- Kees Cook