From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812C1C433EF for ; Mon, 14 Feb 2022 07:26:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21EAB6B0072; Mon, 14 Feb 2022 02:26:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CF8F6B0073; Mon, 14 Feb 2022 02:26:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 098846B0078; Mon, 14 Feb 2022 02:26:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id EAB816B0072 for ; Mon, 14 Feb 2022 02:26:06 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AD8F8180FC152 for ; Mon, 14 Feb 2022 07:26:06 +0000 (UTC) X-FDA: 79140551532.22.021D99A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id 051CC140006 for ; Mon, 14 Feb 2022 07:26:05 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B18F568AFE; Mon, 14 Feb 2022 08:26:01 +0100 (CET) Date: Mon, 14 Feb 2022 08:26:01 +0100 From: Christoph Hellwig To: Zi Yan Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Marek Szyprowski , Robin Murphy , linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Vlastimil Babka , Mel Gorman , Eric Ren , Mike Rapoport , Oscar Salvador Subject: Re: [PATCH v5 3/6] mm: make alloc_contig_range work at pageblock granularity Message-ID: <20220214072601.GA17306@lst.de> References: <20220211164135.1803616-1-zi.yan@sent.com> <20220211164135.1803616-4-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211164135.1803616-4-zi.yan@sent.com> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=none (imf09.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 051CC140006 X-Stat-Signature: qr8iyhtr3yewyupkwmnq58675r8muy8t X-HE-Tag: 1644823565-428810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +int > +isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags, int isolate_before_boundary); Please avoid the completely unreadably long line. i.e. int isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags, int isolate_before_boundary); Same in various other spots.